-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build sentry-native with CXX 14 #6294
Build sentry-native with CXX 14 #6294
Conversation
211a6cc
to
4af5645
Compare
…sible dependencies, exposes CXX 14 code on its headers. This will be addressed in upstream sentry-native getsentry/sentry-native#574
4af5645
to
be71521
Compare
I detected other pull requests that are modifying sentry-native/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
I used the same PR to fix the missing support for breakpad. If you think it would be better to split this in 2, I'll revert my last commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Combining the pr's is no problem for me.
c3i will not test google's breakpad integration anyways.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
All green in build 8 (
|
* Build sentry-native with CXX 14 since sentry-crashpad, one of its possible dependencies, exposes CXX 14 code on its headers. This will be addressed in upstream sentry-native getsentry/sentry-native#574 * Support breakpad and sentry-breakpad as backends * Add minimum compiler version check / raise. * Add pkgconf as build_requirement if breakpad is set as backend
sentry-crashpad
exposes CXX 14 code on its headers, so the build forsentry-native
withcrashpad
as backend fails.I reported this upstream and the devs agreed to make CXX 14 the default.
getsentry/sentry-native#574
Closes #6246
conan-center hook activated.