Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build sentry-native with CXX 14 #6294

Conversation

ericriff
Copy link
Contributor

@ericriff ericriff commented Jul 12, 2021

sentry-crashpad exposes CXX 14 code on its headers, so the build for sentry-native with crashpad as backend fails.
I reported this upstream and the devs agreed to make CXX 14 the default.
getsentry/sentry-native#574

Closes #6246


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@ericriff ericriff force-pushed the eriff/build-sentry-native-with-CXX-14 branch from 211a6cc to 4af5645 Compare July 12, 2021 19:00
…sible dependencies, exposes CXX 14 code on its headers.

This will be addressed in upstream sentry-native
getsentry/sentry-native#574
@ericriff ericriff force-pushed the eriff/build-sentry-native-with-CXX-14 branch from 4af5645 to be71521 Compare July 12, 2021 19:02
@ghost
Copy link

ghost commented Jul 12, 2021

I detected other pull requests that are modifying sentry-native/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ericriff
Copy link
Contributor Author

ericriff commented Jul 12, 2021

I used the same PR to fix the missing support for breakpad. If you think it would be better to split this in 2, I'll revert my last commit.
@madebr

madebr
madebr previously approved these changes Jul 12, 2021
Copy link
Contributor

@madebr madebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combining the pr's is no problem for me.
c3i will not test google's breakpad integration anyways.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ericriff ericriff mentioned this pull request Jul 13, 2021
4 tasks
@conan-center-bot
Copy link
Collaborator

All green in build 8 (fbc7f714a0734fbcbfe2e62309ba718889f2317a):

  • sentry-native/0.4.10@:
    All packages built successfully! (All logs)

  • sentry-native/0.4.9@:
    All packages built successfully! (All logs)

  • sentry-native/0.4.8@:
    All packages built successfully! (All logs)

  • sentry-native/0.2.6@:
    All packages built successfully! (All logs)

  • sentry-native/0.4.7@:
    All packages built successfully! (All logs)

  • sentry-native/0.4.1@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 5ad5718 into conan-io:master Jul 15, 2021
AndreyMlashkin pushed a commit to AndreyMlashkin/conan-center-index that referenced this pull request Jul 19, 2021
* Build sentry-native with CXX 14 since sentry-crashpad, one of its possible dependencies, exposes CXX 14 code on its headers.
This will be addressed in upstream sentry-native
getsentry/sentry-native#574

* Support breakpad and sentry-breakpad as backends

* Add minimum compiler version check / raise.

* Add pkgconf as build_requirement if breakpad is set as backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] sentry-native with sentry-crashpad as backedn fail to compile due to missing CXX standards.
5 participants