Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes sentry-native crashpad compilation on Linux #7036

Merged

Conversation

mjvankampen
Copy link
Contributor

@mjvankampen mjvankampen commented Aug 24, 2021

Specify library name and version: sentry-native/0.4.12

Without this patch sentry does not compile, ref. getsentry/sentry-native#574

Made PR upstream, ref. getsentry/sentry-native#585


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

Without this patch sentry does not compile, ref. getsentry/sentry-native#574
@conan-center-bot

This comment has been minimized.

@jgsogo
Copy link
Contributor

jgsogo commented Aug 26, 2021

Apple-M1 binaries were missing: https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/TapaholesList/244/summary.json. I'm triggering this PR again.

@conan-center-bot

This comment has been minimized.

@jgsogo
Copy link
Contributor

jgsogo commented Aug 27, 2021

It was not only that version. I've triggered the rest:

We would need a PR to sentry-crashpad/0.2.6 to fix (or skip) those cross-building scenarios.

@stale
Copy link

stale bot commented Sep 26, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 26, 2021
@mjvankampen mjvankampen reopened this Sep 28, 2021
@stale stale bot removed the stale label Sep 28, 2021
@conan-center-bot
Copy link
Collaborator

All green in build 3 (354b62af39626e834a8760b0724cb6a70f7aab4d):

  • sentry-native/0.4.12@:
    All packages built successfully! (All logs)

  • sentry-native/0.4.11@:
    All packages built successfully! (All logs)

  • sentry-native/0.4.9@:
    All packages built successfully! (All logs)

  • sentry-native/0.4.10@:
    All packages built successfully! (All logs)

  • sentry-native/0.4.8@:
    All packages built successfully! (All logs)

  • sentry-native/0.4.7@:
    All packages built successfully! (All logs)

  • sentry-native/0.4.1@:
    All packages built successfully! (All logs)

  • sentry-native/0.2.6@:
    All packages built successfully! (All logs)

Copy link
Contributor

@ericriff ericriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been fixed on master, so the next release won't need the patch.

@conan-center-bot conan-center-bot merged commit db5b6a1 into conan-io:master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants