Fix compilation failure in android #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
|
Please, open different PRs if you want to modify several recipes |
lasote
requested changes
Sep 24, 2019
| @@ -96,8 +96,7 @@ def package_info(self): | |||
| self.cpp_info.libs = ['libpng16'] | |||
| else: | |||
| self.cpp_info.libs = ["png16"] | |||
| if self.settings.os == "Linux": | |||
| self.cpp_info.libs.append("m") | |||
| self.cpp_info.libs.append("m") | |||
There was a problem hiding this comment.
Probably is safer to keep the "IF" adding android, otherwise other NIX systems might suffer.
| @@ -85,5 +85,7 @@ def package_info(self): | |||
| self.cpp_info.libs = ['webpmux', 'webpdemux', 'webpdecoder', 'webp'] | |||
| if self.options.shared and self.settings.os == "Windows" and self.settings.compiler != 'Visual Studio': | |||
| self.cpp_info.libs = [lib + '.dll' for lib in self.cpp_info.libs] | |||
| if self.settings.os == "Linux": | |||
| self.cpp_info.libs.append("pthread") | |||
| if self.settings.os != "Windows": | |||
There was a problem hiding this comment.
Same comment, limit changes to Android. It might have collateral issues for NIX systems.
Please do different PRs to change different libraries.
Thanks!
|
Thank you! I will open different PRs. |
artem-kamyshev
pushed a commit
to artem-kamyshev/conan-center-index
that referenced
this pull request
Sep 28, 2020
datalogics-robb
added a commit
to datalogics-robb/conan-center-index
that referenced
this pull request
Sep 3, 2024
Merge in changes from conan-io/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: lib/1.0
conan-center hook activated.