Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let contributors know to avoid rebasing #8797

Merged
merged 3 commits into from
Jan 12, 2022

Conversation

prince-chrismc
Copy link
Contributor

when waiting for automatic merge to pass

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

when waiting for automatic merge to pass
@prince-chrismc prince-chrismc mentioned this pull request Jan 10, 2022
4 tasks
@conan-center-bot

This comment has been minimized.

uilianries
uilianries previously approved these changes Jan 11, 2022
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! Thank you, it makes total sense!

jgsogo
jgsogo previously approved these changes Jan 11, 2022
docs/review_process.md Outdated Show resolved Hide resolved
intelligide
intelligide previously approved these changes Jan 11, 2022
Co-authored-by: Javier G. Sogo <[email protected]>
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Updating docs!

@prince-chrismc
Copy link
Contributor Author

Sorry for dismissing reviews, I wanted to capture the feedback and make sure to note the reasoning 😄
Thanks for that clarification !

@uilianries
Copy link
Member

Sorry for dismissing reviews, I wanted to capture the feedback and make sure to note the reasoning smile Thanks for that clarification !

Thank you for updating it!!

Copy link
Contributor

@SSE4 SSE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally like git rebase, but if it makes life easier for contributors here, I have no objections xD

@conan-center-bot conan-center-bot merged commit 9c13b68 into conan-io:master Jan 12, 2022
miklelappo pushed a commit to miklelappo/conan-center-index that referenced this pull request Feb 9, 2022
* Let contributors know to avoid rebasing

when waiting for automatic merge to pass

* Update docs/review_process.md

Co-authored-by: Javier G. Sogo <[email protected]>

* Update review_process.md

Co-authored-by: Javier G. Sogo <[email protected]>
datalogics-robb pushed a commit to datalogics-robb/conan-center-index that referenced this pull request Mar 6, 2023
…update-from-conan-io

* 'master' of github.com:conan-io/conan-center-index: (480 commits)
  (conan-io#8840) wslay: modernize
  (conan-io#8830) Deprecate diligentgraphics-spirv-tools
  (conan-io#8829) Deprecate diligentgraphics-spirv-headers
  (conan-io#8828) Deprecate diligentgraphics-vulkan-headers
  (conan-io#8819) nanoflann: add 1.4.2 + modernize
  (conan-io#8814) coin-lemon: restore .names["pkg_config"]
  (conan-io#8797) Let contributors know to avoid rebasing
  (conan-io#8809) libalsa: restore .names["pkg_config"] + add ALSA_CONFIG_DIR to runenv_info
  (conan-io#8807) pkgconf: restore .names["pkg_config"]
  (conan-io#8741) spirv-headers: fix pkg_config name + modernize
  (conan-io#8732) oniguruma: modernize
  (conan-io#8684) libtiff: modernize
  (conan-io#8632) cpython: Add PATH variable only if env_vars option is enabled.
  (conan-io#7331) (conan-io#7329) Support Gandiva in Arrow 2.0.0
  (conan-io#8598) add scdoc documentation tool
  (conan-io#8796) backport-cpp: modernize
  (conan-io#8793) cpp-ipc: add version 1.2.0
  (conan-io#8778) variant-lite: modernize
  (conan-io#8777) string-view-lite: modernize
  (conan-io#8775) scope-lite: modernize
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants