Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix plugin compatibility problems with 2023.3 #174

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Nov 13, 2023

No description provided.

Copy link
Contributor

github-actions bot commented Nov 13, 2023

Qodana Community for JVM

29 new problems were found

Inspection name Severity Problems
Unused import directive 🔶 Warning 8
Incorrect string capitalization 🔶 Warning 7
Unused symbol 🔶 Warning 5
Class member can have 'private' visibility ◽️ Notice 3
Property naming convention ◽️ Notice 3
Might be 'const' ◽️ Notice 1
Unnecessary type argument ◽️ Notice 1
Unnecessary local variable ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (78784d0) 0.00% compared to head (301e4a4) 0.00%.
Report is 5 commits behind head on develop2.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop2    #174   +/-   ##
========================================
  Coverage      0.00%   0.00%           
========================================
  Files            21      21           
  Lines           650     650           
  Branches         78      78           
========================================
  Misses          650     650           
Files Coverage Δ
.../main/kotlin/com/jfrog/conan/plugin/cmake/CMake.kt 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czoido czoido marked this pull request as ready for review November 13, 2023 13:00
@czoido czoido merged commit 4b4a73f into develop2 Nov 13, 2023
6 checks passed
@czoido czoido deleted the fix_compat_problems branch October 1, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants