Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy activation of environment #10007

Merged

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Nov 12, 2021

  • Removed Conan integrated cacert. Lets try to run with the Python and system ones, as we agreed after the latest cacert incident
  • Moving the conans.tools.environment_append to internal usage only in conans.util.env.environment_update with much simpler behavior. Users in tools should use Environment()
  • Stop the injection of conan.conf env-vars to every command invocation via the api_method decorator
  • Moved retry, retry wait to new config. Separated retries for core, upload, download and requests, different things
  • New config.get(conf_name, type, default) helper to simplify access to conf
  • Definition of proxies and all network configuration via new conf

Questions:

  • Should core.download:xxx and core.upload:xxx also be core.net.download:xxx?

@memsharded memsharded marked this pull request as ready for review November 15, 2021 14:31
@memsharded memsharded added this to the 2.0.0-alpha2 milestone Nov 15, 2021
Copy link
Contributor

@lasote lasote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leave me a comment about why you don't consider COMPRESSION_LEVEL useful anymore as config and feel free to merge.
Great work!

conans/cli/api/subapi/__init__.py Outdated Show resolved Hide resolved
@memsharded memsharded merged commit 6e6d7a4 into conan-io:develop2 Nov 15, 2021
@memsharded memsharded deleted the feature/develop2_removing_legacy_env branch November 15, 2021 17:23
memsharded added a commit to memsharded/conan that referenced this pull request Nov 16, 2021
* wip

* wip

* wip

* wip

* fix test

* wip

* wip

* removed tools.get_env

* restored env_reader.py name to reduce diff

* restored environment_append

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* fix win

* added gzip compresslevel

* Update conans/cli/api/subapi/__init__.py

Co-authored-by: Luis Martinez <[email protected]>

Co-authored-by: Luis Martinez <[email protected]>
memsharded added a commit that referenced this pull request Nov 16, 2021
* introducing new version_range

* added tilde and caret

* Update conans/model/recipe_ref.py

Co-authored-by: Luis Martinez <[email protected]>

* Update conans/model/recipe_ref.py

Co-authored-by: Luis Martinez <[email protected]>

* Remove legacy activation of environment (#10007)

* wip

* wip

* wip

* wip

* fix test

* wip

* wip

* removed tools.get_env

* restored env_reader.py name to reduce diff

* restored environment_append

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* fix win

* added gzip compresslevel

* Update conans/cli/api/subapi/__init__.py

Co-authored-by: Luis Martinez <[email protected]>

Co-authored-by: Luis Martinez <[email protected]>

* Improved: Search + List API and [list+search] commands (#10014)

* All broken, trying to desing better API in list/search to be used in other commands like remove and upload

* Keep remove to later

* Still working on search and list API

* Testing apis

* Passing tests

* small fixes

* references back to list and moved get configurations to list

* Feature/develop2 all lowercase (#9985)

* wip

* wip

* wip

* fixing tests

* wip

* wip

* fix tets

* fix tests

* remove virtual-envs auto-use (#10011)

* remove circular imports

* removing dead new -t files (#10003)

* merged upstream

Co-authored-by: Luis Martinez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants