-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow meson wrapper to use backends other than ninja #10447
Allow meson wrapper to use backends other than ninja #10447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would need some tests to check it is working. Could be unit or integration, not necessary full functional test.
Thanks for contributing!
Thanks again for your PR @Makogan As @memsharded said, please, it would be great some tests checking it. As a suggestion, have a look at the tests from |
I added a unit test and I am trying to run it, the docs say to do
|
If you are adding 1 or just a very few unit tests, the best is to run them directly with |
Hi @Makogan! I have added a simple unit test to check that it's working the change made for other backends and a little refactor to have only one |
Sorry I had some personal and professional issues and forgot about the PR. |
Don't worry at all @Makogan |
Changelog: Fix: Let legacy
Meson
build helper use other backends apart fromninja
.Docs: omit
develop
branch, documenting this one.Issue: #10440
Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.