[develop2] Try to revert check_min_cppstd to use self.settings instead of self.info.settings
#12555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
commented
Nov 17, 2022
| @@ -155,8 +155,8 @@ def _process_node(self, node, build_mode): | |||
| if self._evaluate_is_cached(node): | |||
| return | |||
|
|
|||
| if node.conanfile.info.invalid and node.conanfile.info.invalid[0] == BINARY_ERROR: | |||
| node.binary = BINARY_ERROR | |||
| if node.conanfile.info.invalid: | |||
There was a problem hiding this comment.
This is the main change. Once it is invalid, we are done, always.
franramirez688
approved these changes
Nov 17, 2022
This was referenced Nov 17, 2022
|
Immediately off to a better start! log.txt Everything installs and can pass the validate method -- TDB if they are correct but it's working much closed to how I expected. Using this graph.html.txt only my Catch2 recipe is not from ConanCenter -- its conan-io/conan-center-index#13794 + my changes (see PR for details). 🚀 With this PR I can actually install all my deps for the first time < --- this is huge for me ! |
1 task
prince-chrismc
pushed a commit
to prince-chrismc/user-management
that referenced
this pull request
Nov 18, 2022
czoido
approved these changes
Nov 18, 2022
jcar87
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #11786
Close #12210
Close #12072