Feature/msvc msbuild #8238
Merged
Feature/msvc msbuild #8238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danimtb
approved these changes
Jan 18, 2021
czoido
reviewed
Jan 18, 2021
czoido
reviewed
Jan 18, 2021
Co-authored-by: Carlos Zoido <[email protected]>
Co-authored-by: Carlos Zoido <[email protected]>
czoido
approved these changes
Jan 18, 2021
…determine -rpath separator (conan-io#7716) * Fix conan-io#7715, in rpath_flags use host OS instead of build OS to determine the separator for the ld -rpath flag which is neccessary for cross-compiling to Mac OS * For conan-io#7715, don't pass os_host to rpath_flags but extract from settings, pass os_build again and only set rpath_separator to , if compiling for Mac OS from Linux or Mac OS via GCC_LIKE * Fix test_compiler_args for cross-compiling Mac OS X -> Linux * Update conans/client/build/compiler_flags.py Co-authored-by: SSE4 <[email protected]> * Update conans/client/build/compiler_flags.py Co-authored-by: SSE4 <[email protected]> * Update conans/test/unittests/client/generators/compiler_args_test.py * Update conans/client/build/compiler_flags.py * Use -rpath, in all tests for all platforms * fixing tests Co-authored-by: James <[email protected]> Co-authored-by: SSE4 <[email protected]>
…o#8338) * use target without namespace * add marks * use target from the build-module * remove line * build-module per generator * revert changes in build_info * make it explicit it is PATH * even without build-type, compiler.runtime is different for Release/Debug * use x64 for Windows generator
jgsogo
reviewed
Jan 18, 2021
| @@ -138,7 +136,7 @@ def package_info(self): | |||
| pc_path = os.path.join(client.current_folder, "MyLib.pc") | |||
| self.assertTrue(os.path.exists(pc_path)) | |||
| pc_content = load(pc_path) | |||
| self.assertIn("-Wl,-rpath=\"${libdir}\"", pc_content) | |||
| self.assertIn("-Wl,-rpath,\"${libdir}\"", pc_content) | |||
There was a problem hiding this comment.
These changes, was it a bug? Maybe this is worth an entry in the changelog.
There was a problem hiding this comment.
There was another PR for this issue, not this one, I am surprised this is here, need to check.
There was a problem hiding this comment.
The PR https://github.com/conan-io/conan/pull/7716/files contains this change, and this was merged to develop, and this PR merged develop, so I think it might be a glitch of Github diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Provide support for
msvccompiler inMSBuildtoolsDocs: conan-io/docs#1991
Follow up of #8201, to provide support for
msvccompiler inMSBuildtoolsSame initial experimental support, just extending it for
tools.microsoft(it was only for CMake):core.package_id:msvc_visual_compatiblein new conan.cfg