Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New cppinfo and CMakeDeps as example of usage #8766

Merged
merged 87 commits into from
Apr 20, 2021
Merged

New cppinfo and CMakeDeps as example of usage #8766

merged 87 commits into from
Apr 20, 2021

Conversation

lasote
Copy link
Contributor

@lasote lasote commented Apr 6, 2021 •
edited
Loading

Changelog: omit
Docs: omit

Summary:

  • Not using deps_cpp_info in the generator anymore.
  • Simplified cppinfo class that now doesn't use root folders internally until the usage of to_absolute_paths(self, root_folder).

NOTE: Removed multi config packages

memsharded
memsharded reviewed Apr 19, 2021
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge step forward, way more clear, readable and structured, I love it.

My only concern would be the migration path for this, lets talk and lets have this merged for next 1.36!

conan/tools/cmake/cmakedeps.py Outdated Show resolved Hide resolved
conans/model/new_build_info.py Show resolved Hide resolved
@lasote lasote marked this pull request as ready for review April 19, 2021 15:16
@memsharded memsharded added this to the 1.36 milestone Apr 20, 2021
@memsharded memsharded merged commit b3d5245 into conan-io:develop Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.36
Development

Successfully merging this pull request may close these issues.
3 participants
@lasote @memsharded @czoido