Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added root certificate for Let's encrypt #9696

Closed

Conversation

lasote
Copy link
Contributor

@lasote lasote commented Sep 30, 2021

Changelog: Bugfix: Added root certificate for Let's encrypt.
Docs: omit

More info here.

Clos[e] #9695

@lasote lasote changed the base branch from develop to release/1.40 September 30, 2021 15:06
@lasote lasote added this to the 1.40.3 milestone Sep 30, 2021
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A migration is needed removing cacert.pem, so it installs the new one.

@lasote lasote closed this Sep 30, 2021
@czoido czoido removed this from the 1.40.3 milestone Sep 30, 2021
@Hrungnir
Copy link

And you just broke everyone that added self-signed certs in the cacerts.pem file

@memsharded
Copy link
Member

And you just broke everyone that added self-signed certs in the cacerts.pem file

Everyone adding self-signed certs in the cacert.pem file should just add the new certificate to their cacert.pem file and let their conan config install update it. Custom changes to files in the cache, (including cacert.pem) have been recommended to be managed with conan config install since a long time ago.

@Hrungnir
Copy link

makes sense, I appreciate the reply, perhaps the TLS section of the docs or conan config install just need a update regarding best practices here.

@memsharded
Copy link
Member

makes sense, I appreciate the reply, perhaps the TLS section of the docs or conan config install just need a update regarding best practices here.

Yes, it is very likely that the docs could be improved, thanks for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] Unable to connect to conancenter=https://center.conan.io
4 participants