[Bugfix] CMakeDeps and options for linking
#9980
Conversation
franramirez688
force-pushed
the
bugfix/cmakedeps_and_sharedlinkflags
branch
from
24b65df
to
47d80fe
Compare
conans/test/functional/toolchains/cmake/cmakedeps/test_cmakedeps_and_linker_flags.py
Show resolved
Hide resolved
| @@ -215,8 +218,8 @@ def join_paths_single_var(values): | |||
| # linker flags without magic: trying to mess with - and / => | |||
| # https://github.com/conan-io/conan/issues/8811 | |||
| # frameworks should be declared with cppinfo.frameworks not "-framework Foundation" | |||
| self.sharedlinkflags_list = join_flags(";", cpp_info.sharedlinkflags) | |||
| self.exelinkflags_list = join_flags(";", cpp_info.exelinkflags) | |||
| self.sharedlinkflags_list = join_flags(";", cpp_info.sharedlinkflags, as_string=True) | |||
There was a problem hiding this comment.
This is a bit confusing. The self.xxxx_list variable was created to explicitly represent it contains a list of flags, not a unique string. Maybe we want to return to the sharedlinkflags variable? This was added because some CMake was complaining about receiving a string and it always needed a list, but better double check it.
There was a problem hiding this comment.
Yes, but the thing is that it's still a list of flags but passed as a string. I mean, internally, CMake is reading it as a list of flags -> "oneflag;otherflag;-z flag".
I don't know what it was doing before but this is the recommended way to pass it, isn't it? For me, what could be confusing is the parameter as_string, any suggestion?
There was a problem hiding this comment.
I would remove the as_string and quote the final string in the assignation directly.
franramirez688
force-pushed
the
bugfix/cmakedeps_and_sharedlinkflags
branch
from
ca455d8
to
b1f9c53
Compare
| @@ -215,8 +218,8 @@ def join_paths_single_var(values): | |||
| # linker flags without magic: trying to mess with - and / => | |||
| # https://github.com/conan-io/conan/issues/8811 | |||
| # frameworks should be declared with cppinfo.frameworks not "-framework Foundation" | |||
| self.sharedlinkflags_list = join_flags(";", cpp_info.sharedlinkflags) | |||
| self.exelinkflags_list = join_flags(";", cpp_info.exelinkflags) | |||
| self.sharedlinkflags_list = join_flags(";", cpp_info.sharedlinkflags, as_string=True) | |||
There was a problem hiding this comment.
I would remove the as_string and quote the final string in the assignation directly.
Changelog: Bugfix: CMakeDeps generated
*-data.cmakewas not including properly the set of link flags.Changelog: Bugfix: CMakeDeps was not populating
INTERFACE_LINK_OPTIONSto each target.Closes: #9936
Docs: omit
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.