- Feature: add backend support to MesonToolchain #9990
Conversation
Signed-off-by: SSE4 <[email protected]>
|
Could we add a test using the visual backend? |
Signed-off-by: SSE4 <[email protected]>
sure, I've added some test |
| client.run("build .") | ||
| client.run_command(os.path.join("build", "demo")) | ||
|
|
||
| assert "main _M_X64 defined" in client.out |
There was a problem hiding this comment.
It is very likely that this would be identical irrespective of the backend. If it is, and we cannot test the backend this way, then maybe move this test to "integration" make it faster (no need to compile anything), and just check the generated conan_meson_native.ini?
There was a problem hiding this comment.
Please check this @SSE4 if possible, to get this merged to 1.43
There was a problem hiding this comment.
I am not sure what do you mean by we cannot test the backend this way.
we can test, and it's already tested that way. we build an executable and verify it can be run successfully, and was compiled for the proper architecture.
There was a problem hiding this comment.
It is very likely that this would be identical irrespective of the backend.
I am also not sure about this one. in case of ninja (default), there is ninja build generated and built via ninja.
in case of vs backend, it generates vcxproj file and built it via msbuild.
in second case you can use an IDE to open and edit the project. so it's not identical.
There was a problem hiding this comment.
The output of running the compiled executable depends only in the compiler (and the conan settings), it should be the same with either backend. So this test output checks will still pass even if the backend was not vs. The only valid check in this test is the one checking backend = "vs", and the test can stop there, unless some other check is done, like checking the output of Meson for something like "Using the Visual Studio backend".
There was a problem hiding this comment.
What I am saying is that the test should somehow check that the VS is currently in use, and there is nothing there.
I doubt it's worth implementing that check, to be honest. the only way to check is to verify which process is executed during the meson build (like msbuild.exe or devenv.exe or whatever), and this process is launched from another child process of the conan client, so it's tricky to handle that.
There was a problem hiding this comment.
Restored the check. Added assert "Auto detected Visual Studio backend" in client.out to the test.
Now, there is some good evidence that Meson is actually using the Visual Studio backend.
There was a problem hiding this comment.
Sorry, I messed with the branches. I will restore things.
There was a problem hiding this comment.
okay, it might be enough for our purposes. it only verifies that meson prints something (e.g. claims that it uses Visual Studio backend), but we still don't know does it actually use it. but even if it doesn't, I'd say it's meson bug and not our problem :)
There was a problem hiding this comment.
Yes, that would be a Meson bug. Our job ends verifying that Meson uses that VS backend, and that check should be enough with it.
memsharded
force-pushed
the
meson_backend
branch
from
2b466d3
to
db86de2
Compare
* - [MesonToolchain] add backend support Signed-off-by: SSE4 <[email protected]> * - add test Signed-off-by: SSE4 <[email protected]> * - move Signed-off-by: SSE4 <[email protected]> * fixed wrong develop2 merge, added test check for VS backend Co-authored-by: memsharded <[email protected]>
Changelog: Feature: Add backend support to MesonToolchain.
Docs: conan-io/docs#2295
Closes: #9922
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.