Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename composer package #772

Merged

Conversation

mlocati
Copy link
Contributor

@mlocati mlocati commented Jun 12, 2023

Better to do it now, before someone starts using Community Store via Composer.

@Mesuva Mesuva merged commit 4018f49 into concretecms-community-store:master Jun 12, 2023
@mlocati mlocati deleted the rename-composer-package branch June 12, 2023 14:47
@Mesuva
Copy link
Collaborator

Mesuva commented Jun 12, 2023

Yep, I've made this change locally. There's also the type, which I'm not 100% sure if it's valid to be:
"type": "concretecms-package",

But that's what I'll be changing it to, unless you can advise otherwise.

@mlocati
Copy link
Contributor Author

mlocati commented Jun 12, 2023

Nope, we can't change the type, otherwise Composer won't install it in the right location (that is, in the packages directory instead of under the vendor directory) - see https://github.com/composer/installers/blob/main/src/Composer/Installers/Concrete5Installer.php

@Mesuva
Copy link
Collaborator

Mesuva commented Jun 12, 2023

Interesting!
I'll be looking into Packagist as well as your github action suggestion soon. Really appreciate your involvement here.

@mlocati
Copy link
Contributor Author

mlocati commented Jun 12, 2023

We'd need this change in order to use concretecms-package instead of concrete5-package (and we have to wait for a new composer/installers release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants