Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v5.1 #10

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AndresGuzman-Ballen
Copy link

Checklist

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@AndresGuzman-Ballen
Copy link
Author

@conda-forge-admin, please rerender

Copy link
Member

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to bump the minimal llvm-openmp version

@ekomarova
Copy link

@isuruf Do we need to change the version here https://github.com/conda-forge/openmp-feedstock/blob/main/recipe/meta.yaml#L4, right?

@AndresGuzman-Ballen
Copy link
Author

Should this do the trick? conda-forge/openmp-feedstock#83

@isuruf
Copy link
Member

isuruf commented Apr 13, 2023

I mean we need to change line 32 in this recipe/meta.yaml file

@h-vetinari
Copy link
Member

LLVM is far from full support for 5.0 & 5.1. I don't think we should raise the version before that happens.

@h-vetinari
Copy link
Member

I suggest moving the discussion to conda-forge/openmp-feedstock#96. Spoiler: LLVM 17 will default to openmp 5.1, but support does not appear complete yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants