-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to v5.1 #10
base: main
Are you sure you want to change the base?
Update to v5.1 #10
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.04.11.10.49.54
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to bump the minimal llvm-openmp
version
@isuruf Do we need to change the version here https://github.com/conda-forge/openmp-feedstock/blob/main/recipe/meta.yaml#L4, right? |
Should this do the trick? conda-forge/openmp-feedstock#83 |
I mean we need to change line 32 in this recipe/meta.yaml file |
LLVM is far from full support for 5.0 & 5.1. I don't think we should raise the version before that happens. |
I suggest moving the discussion to conda-forge/openmp-feedstock#96. Spoiler: LLVM 17 will default to openmp 5.1, but support does not appear complete yet. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)