-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
altair v4.2.1 without jsonschema upper bound #43
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Just a note that there will likely be a 4.2.2 release coming in a few days too that fixes the jsonschema issue vega/altair#2857 (comment) |
Should we then add a |
I think for 4.2.2 at least yes. Maybe we could even skip this 4.2.1 release in conda and wait for 4.2.2? |
I interpreted vega/altair#2857 (comment) as meaning that
I would suggest to just merge this with a reasonable constraint and keep pypi and conda-forge releases in sync. |
Please note that the jsonschema version number
|
I'm ok to merge this with the correction @binste mentioned above |
Please wait with the merge, I need to check something |
So many version numbers flying around :) Found the correct release of jsonschema which introduced the Updated my comment above. What we want is Compatibility looks as follows:
Sorry for any confusion. |
Co-authored-by: Stefan Binder <[email protected]>
@jtilly do you still need this PR to be merged? |
No, thank you. I think 4.2.2 is enough. |
Closes #42
This PR removes the upper bound on jsonschema for 4.2.1. This PR should merged instead of #42.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)