Backport Azure/azure-sdk-for-cpp#4982
#6
Conversation
Signed-off-by: Julien Jerphanion <[email protected]> Co-authored-by: Phoebus Mak <[email protected]>
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.10.02.03.27.19
jjerphan
requested review from
teo-tsirpanis,
Shelnutt2 and
jdblischak
as code owners
| +#if defined(_azure_SUPPORT_SETTING_CAPATH) | ||
| + /** | ||
| + * @brief Path to a directory which holds PEM encoded file, containing the certificate | ||
| + * authorities sent to libcurl handle directly. | ||
| + * | ||
| + * @remark The Azure SDK will not check if the path is valid or not. | ||
| + * | ||
| + * @remark The default is the built-in system specific path. More about this option: | ||
| + * https://curl.se/libcurl/c/CURLOPT_CAPATH.html | ||
| + * | ||
| + */ | ||
| + std::string CAPath; | ||
| +#endif |
There was a problem hiding this comment.
This introduces a new public API. Are we sure it can be backported?
There was a problem hiding this comment.
I am not entirely sure, indeed. Also a maintainer of the Azure SDK for C++ mentioned that the next release should happen sometime soon (see Azure/azure-sdk-for-cpp#4982 (comment)). Probably we wait for it?
There was a problem hiding this comment.
That looks like a better choice.
There was a problem hiding this comment.
To hopefully clarify, we are planning to release this change as 1.11.0-beta.1 on Thursday, October 5th.
Please note, since this goes to a beta release, and the beta release is for the library already had stable releases, the further Betas do not go to the official vcpkg repo. Usually, the beta changes are baked for a month until they are released in stable release. If you are looking for this change to appear in the vcpkg official repo, you'll probably need to wait until, I'd say, November 10th.
Otherwise, this change will be available in our Beta vcpkg registry - https://github.com/Azure/azure-sdk-vcpkg-betas - it should happen on October 5th.
There was a problem hiding this comment.
Thanks for chiming in @antkmsft! BTW, when can we expect the next stable release of azure-identity-cpp?
There was a problem hiding this comment.
We are targeting the November timeframe for the next stable release of azure-identity-cpp, if not sooner.
Is there something particular you are hoping to use from there? We'd love to get some usage feedback on the beta release to help stabilize it.
|
Closing in preference to the next release of the SDK. |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Backport Azure/azure-sdk-for-cpp#4982
Disclosure: this is a request from
man-group/arcticdb.