Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MacOS 13.3 SDK #281

Merged
merged 7 commits into from
Sep 24, 2023
Merged

Conversation

bollwyvl
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

References:

@bollwyvl bollwyvl requested a review from a team as a code owner September 22, 2023 22:19
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

recipe/download_osx_sdk.sh Outdated Show resolved Hide resolved
@bollwyvl
Copy link
Contributor Author

I don't know much about this repo... anything else what needs doing? Tests?

@isuruf
Copy link
Member

isuruf commented Sep 23, 2023

Can you add a recipe/conda_build_config.yaml with MACOSX_SDK_VERSION: 13.3 and rerender? Then we should be able to see if it works.

@bollwyvl
Copy link
Contributor Author

@conda-forge-admin please rerender

@bollwyvl
Copy link
Contributor Author

Looks like it did the thing:

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=786578&view=logs&j=15f8dc28-9f6f-5e3a-5b3c-2b169071e5be&t=63fa899e-c160-5185-75c4-c5fd30c90374&l=346

So presumably now remove that, and rerender?

@bollwyvl
Copy link
Contributor Author

Should i be worried about the remaining changes? Just hard revert back to fcafa88 ?

@beckermr
Copy link
Member

They look fine to me!

@isuruf isuruf merged commit e5c0647 into conda-forge:main Sep 24, 2023
57 checks passed
@bollwyvl
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support MACOSX_SDK_VERSION 13.3
3 participants