-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tighten depends max_pin="x.x.x" for all azure-sdk-for-cpp packages #674
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@jjerphan @teo-tsirpanis @Shelnutt2 Please review |
39cd0a5
to
973e3c2
Compare
I had forgotten to include the Here are the results of the linux-64 architecture from running locally:
|
Here is the full output from the CI job: Full diff
|
It appears that no conda-forge packages currently depend on azure-storage-files-datalake-cpp, azure-storage-files-shares-cpp, or azure-storage-files-shares-cpp. I kind of like including them here for documentation purposes, but since they don't have any effect, I am happy to remove those 3 patches from the PR if requested. |
@conda-forge/core Repodata patch ready for review |
Checklist
generate_patch_json.py
if absolutely necessary.pre-commit run -a
and ensured all files pass the linting checks.python show_diff.py
and posted the output as part of the PR.Timeline:
We originally added the azure-sdk-for-cpp libraries with a run exports max pin of
x
(azure-sdk-for-cpp: core, identity, storage staged-recipes#23297)The azure-core-cpp 1.11.0 update broke tiledb on Linux (The azure-core-cpp 1.11.0 update broke tiledb tiledb-feedstock#228)
We submitted minimal repodata patches to only address the issue with azure-core-cpp 1.11.0 and tiledb (Set upper_bound of 1.11.0 for tiledb binaries that depend on azure-core-cpp #639 &Extend azure-core-cpp 1.10 patch for tiledb #649)
We learned from the Azure SDK for C++ maintainers that they do not guarantee binary compatibility between any releases (azure-core-cpp version 1.11.0 introduced a binary breaking change. Azure/azure-sdk-for-cpp#5322)
Thus we updated all the recipes to use a run exports max pin of
x.x.x
(Use run_exports max_pin of x.x.x azure-core-cpp-feedstock#14, Use run_exports max_pin of x.x.x azure-identity-cpp-feedstock#6, Use run_exports max_pin of x.x.x azure-storage-blobs-cpp-feedstock#10, Use run_exports max_pin of x.x.x azure-storage-common-cpp-feedstock#13, Use run_exports max_pin of x.x.x azure-storage-files-datalake-cpp-feedstock#8, Use run_exports max_pin of x.x.x azure-storage-files-shares-cpp-feedstock#7, Use run_exports max_pin of x.x.x azure-storage-queues-cpp-feedstock#6)This repodata patch is the final step to ensure no future problems due to insufficient pins of the azure-sdk-for-cpp libraries