-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH add patches for new conda-build release #686
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
FWIW, I'm not aware of any changes in |
Right. I am trying to be proactive, but we can keep this open until the removal in two months or so. |
I agree that this should only do |
The only thing left to do is make a smithy release with the latest fixes. Then we'll know the time bound in this patch is correct and we can merge this. |
To understand if the repodata patch is correct, we'd have to test smithy with conda-build 24.3, right? Hence this would require merging conda-forge/conda-build-feedstock#221. From what I can tell, the risk should be low, again because 24.3 doesn't yet actually remove anything; Marcel's patches were already aimed at compat with 24.5. |
These are deprecations and removals of apis. The smithy PR already tested the alternate code paths in the smithy test suite. |
I'm not sure I follow what you're trying to say, but if a smithy release needs to happen, can we do that? |
@conda-forge-admin, please restart ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that conda-smithy
has been released, this LGTM!
CI log shows unrelated changes: osx-arm64::clang-15.0.7-h30cc82d_5.conda
+ "constrains": [
+ "clang-tools 15.0.7.*",
+ "llvm 15.0.7.*",
+ "llvm-tools 15.0.7.*",
+ "llvmdev 15.0.7.*"
+ ],
osx-arm64::clang-tools-15.0.7-default_he012953_5.conda
- "clangdev 15.0.7"
+ "clang 15.0.7.*",
+ "clangdev 15.0.7",
+ "llvm 15.0.7.*",
+ "llvm-tools 15.0.7.*",
+ "llvmdev 15.0.7.*" |
Opened issues upstream in the feedstocks at |
Checklist
generate_patch_json.py
if absolutely necessary.pre-commit run -a
and ensured all files pass the linting checks.python show_diff.py
and posted the output as part of the PR.