Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for correctly resolving stdlib #1888

Merged
merged 4 commits into from
Mar 23, 2024
Merged

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Mar 23, 2024

Closes #1840, needs conda-build 24.3; tested locally with artefacts from conda-forge/conda-build-feedstock#220

@h-vetinari
Copy link
Member Author

I'm actually surprised that this passes with conda-build 24.1.2; I thought that conda/conda-build#5195 would have been necessary, but I guess by adding c_stdlib{,_version} to always_keep_keys, we're not actually dependent on that PR after all... CC @mbargull

@h-vetinari h-vetinari marked this pull request as ready for review March 23, 2024 05:09
@h-vetinari h-vetinari requested a review from a team as a code owner March 23, 2024 05:09
@beckermr beckermr merged commit cac8e1b into conda-forge:main Mar 23, 2024
2 checks passed
@h-vetinari h-vetinari deleted the stdlib branch March 23, 2024 12:26
@jakirkham
Copy link
Member

This is great! Thanks Axel 🙏

@mbargull
Copy link
Member

I'm actually surprised that this passes with conda-build 24.1.2; I thought that conda/conda-build#5195 would have been necessary, but I guess by adding c_stdlib{,_version} to always_keep_keys, we're not actually dependent on that PR after all... CC @mbargull

Well, sure, without conda/conda-build#5195, the key is not recognized as used; if you override the logic with the (conda-smithy-specific) always_keep_keys thing, you don't depend on it being recognized, of course.

@h-vetinari
Copy link
Member Author

Yeah, I didn't know the inner workings of conda-{build,smithy} well enough to understand that, sorry...

@mbargull
Copy link
Member

Ah, no need to apologize!
We needed the fix in conda-build anyway since we have support uses outside of conda-smithy rerender workflows ;).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: correctly rerender CI configs with new stdlib jinja-function
4 participants