Prevent slowdown in yum due to high file descriptor count #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckermr
requested changes
Jun 24, 2024
Set the maximum number of file descriptors to 1024 before going through the `yum install` step of the build, only in case `yum_requirements.txt` is present in the recipe. This is done to mitigate a bug with old versions of rpm such as the one shipped with the Centos7 container. See https://bugzilla.redhat.com/show_bug.cgi?id=1537564
vepadulano
force-pushed
the
yum-fix-ulimit
branch
from
5b64441
to
4f909fd
Compare
Seems like a reasonable request! I modified the commit, let me know if it looks good 👍 |
beckermr
requested changes
Jun 24, 2024
|
Thank you so much @beckermr for your prompt reply and help! |
mbargull
reviewed
Jun 24, 2024
Comment on lines
65
to
69
| # Due to https://bugzilla.redhat.com/show_bug.cgi?id=1537564 old versions of rpm | ||
| # are drastically slowed down when the number of file descriptors is very high. | ||
| # This can be visible during a `yum install` step of a feedstock build. | ||
| ulimit -n 1024 | ||
| {{ yum_build_setup }}{% endif -%} |
There was a problem hiding this comment.
Let's put this in a subshell to make this as locally as possible.
Suggested change
| # Due to https://bugzilla.redhat.com/show_bug.cgi?id=1537564 old versions of rpm | |
| # are drastically slowed down when the number of file descriptors is very high. | |
| # This can be visible during a `yum install` step of a feedstock build. | |
| ulimit -n 1024 | |
| {{ yum_build_setup }}{% endif -%} | |
| ( | |
| # Due to https://bugzilla.redhat.com/show_bug.cgi?id=1537564 old versions of rpm | |
| # are drastically slowed down when the number of file descriptors is very high. | |
| # This can be visible during a `yum install` step of a feedstock build. | |
| # => Set a lower limit in a subshell for the `yum install`s only. | |
| ulimit -n 1024 | |
| {{ yum_build_setup }} | |
| ){% endif -%} |
(Alternatively, we could also put this is in yum_build_setup directly; IDK what the preference would be.)
There was a problem hiding this comment.
(unresolved for visibility)
There was a problem hiding this comment.
Alternatively, we could also put this is in yum_build_setup directly
Handling in PR: #1961
This also fixed a formatting issue Jinja blank space cleanup otherwise introduces
Co-authored-by: Marcel Bargull <[email protected]>
mbargull
approved these changes
Jun 24, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
newsentryI am one of the maintainers of the ROOT project conda-forge feedstock at https://github.com/conda-forge/root-feedstock . We make use of the
yum_requirements.txtfeature which triggers ayum installstep in our build with the necessary package. I always noticed that this takes a huge amount of time due to this bug and I always manually set the number of file descriptors when developing locally. I thought it would be a good idea to upstream this to conda-smithy. Let me know if it makes sense and if I'm missing anything relevant in the changes. Thank you so much for the great project!