Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 lint: add end to end tests #2029

Merged
merged 18 commits into from
Aug 10, 2024
Merged

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Aug 9, 2024

This actually uncovered a few issues :)

@wolfv wolfv requested a review from a team as a code owner August 9, 2024 07:00
Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bug fixes. One comment on not mixing PRs.

conda_smithy/linter/lints.py Outdated Show resolved Hide resolved
@beckermr
Copy link
Member

beckermr commented Aug 9, 2024

ok @wolfv - have fun rebasing!

@wolfv
Copy link
Member Author

wolfv commented Aug 9, 2024

On it! :)

@wolfv
Copy link
Member Author

wolfv commented Aug 9, 2024

OK done! :)

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One item.

tests/test_lint_recipe.py Outdated Show resolved Hide resolved
@beckermr
Copy link
Member

LGTM and thank you!

@beckermr beckermr merged commit abec53e into conda-forge:main Aug 10, 2024
2 checks passed
@wolfv wolfv deleted the end-to-end-tests branch August 10, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants