Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to cross-compilation for linux_aarch64 #10

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Apr 10, 2024

This PR switches to cross-compilation for linux_aarch64.

See conda-forge/cuda-feedstock#25

@bdice bdice requested a review from a team as a code owner April 10, 2024 17:09
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge.yml Outdated
@@ -1,3 +1,6 @@
build_platform:
linux_aarch64: linux_64
linux_ppc64le: linux_64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently linux_ppc64le is not supported on this feedstock. Please see PR ( #4 ), which attempts to add linux_ppc64le, but runs into issues

However it looks like adding linux_ppc64le to build_platform is resulting in builds being added for that platform. So think we need to drop it to disable linux_ppc64le builds

Suggested change
linux_ppc64le: linux_64

@jakirkham jakirkham changed the title Switch to cross-compilation for linux_aarch64 and linux_ppc64le Switch to cross-compilation for linux_aarch64 Apr 10, 2024
@jakirkham
Copy link
Member

Have amended the commit to make this just for linux_aarch64 and updated the OP & title accordingly. Hope that is ok

@jakirkham jakirkham added the automerge Merge the PR when CI passes label Apr 10, 2024
@github-actions github-actions bot merged commit 15a4682 into conda-forge:main Apr 10, 2024
4 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants