Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to cross-compilation for linux_aarch64 and linux_ppc64le #7

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Apr 10, 2024

This PR switches to cross-compilation for linux_aarch64 and linux_ppc64le.

See conda-forge/cuda-feedstock#25

@bdice bdice requested a review from a team as a code owner April 10, 2024 17:09
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@@ -15,7 +15,7 @@ source:
sha256: 2e402c471dedcc41bb0be2517a836bdadcc539ce799fb7599304c5ffdc7dc566 # [ppc64le]

build:
number: 0
number: 1
skip: true # [aarch64 or osx or win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note that linux_aarch64 is skipped here, so this just builds for linux_ppc64le

Comment on lines +1 to +3
build_platform:
linux_aarch64: linux_64
linux_ppc64le: linux_64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said, it is ok to include both here as we did in the Arch Migrator PR ( #1 )

If this feedstock were to add linux_aarch64, we would be able to use cross-compilation to start

@jakirkham
Copy link
Member

It looks like re-rendering didn't happen here. So am going to ask the bot to pick that up

@conda-forge-admin , please re-render

@jakirkham jakirkham added the automerge Merge the PR when CI passes label Apr 10, 2024
@github-actions github-actions bot merged commit 4c36b79 into conda-forge:main Apr 10, 2024
4 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants