Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for CUDA12.5.1 #23

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Update for CUDA12.5.1 #23

merged 4 commits into from
Jul 8, 2024

Conversation

adibbley
Copy link
Contributor

@adibbley adibbley commented Jul 8, 2024

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.
  • You're setting a requirement on sysroot_linux- directly; this should now be done by adding a build dependence on {{ stdlib("c") }}, and overriding c_stdlib_version in recipe/conda_build_config.yaml for the respective platform as necessary. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

@adibbley
Copy link
Contributor Author

adibbley commented Jul 8, 2024

@conda-forge-admin, please rerender

@adibbley adibbley marked this pull request as ready for review July 8, 2024 19:44
@adibbley adibbley requested a review from a team as a code owner July 8, 2024 19:44
@adibbley adibbley merged commit 938b371 into conda-forge:main Jul 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant