Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to cross-compilation for linux_aarch64 and linux_ppc64le #9

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Apr 10, 2024

This PR switches to cross-compilation for linux_aarch64 and linux_ppc64le.

See conda-forge/cuda-feedstock#25

@bdice bdice requested a review from a team as a code owner April 10, 2024 17:09
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@@ -21,7 +21,7 @@ source:
sha256: bd434d759948b4ef9d9e663b89f5019ea104afec6bf7a17267c624b0bfbc1a03 # [win]

build:
number: 0
number: 1
binary_relocation: false
skip: true # [osx or aarch64]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently linux_aarch64 is skipped. So this only affects linux_ppc64le

That said, the Arch Migrator PR ( #1 ) configured both Linux architectures for builds. So it makes sense to configure both for cross-compilation

That way it is easy to benefit from the cross-compilation changes should linux_aarch64 be added here

@jakirkham jakirkham merged commit c5a62e5 into conda-forge:main Apr 10, 2024
5 checks passed
@jakirkham
Copy link
Member

Thanks Bradley! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants