Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.0b2 release #26

Merged
merged 11 commits into from
Aug 3, 2021
Merged

8.0b2 release #26

merged 11 commits into from
Aug 3, 2021

Conversation

oliver-sanders
Copy link
Contributor

@oliver-sanders oliver-sanders commented Jul 29, 2021

Includes:

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@oliver-sanders
Copy link
Contributor Author

@kinow could we rebuild the changes from #11 on the 8.0b2 release timeframe?

@kinow
Copy link
Member

kinow commented Jul 29, 2021

@kinow could we rebuild the changes from #11 on the 8.0b2 release timeframe?

I don't think so. That PR worked with Py 3.7 and 3.8 I think. But not 3.9. And I did my very shallow test, of using five and some basic Cylc commands. I would be more confident if we had time to have someone like you or Hilary to play with the generated artifacts and see if there's nothing broken.

We can add for next beta or full release though.

@oliver-sanders
Copy link
Contributor Author

(tests will fail until merged into release branch)

@kinow
Copy link
Member

kinow commented Aug 2, 2021

@conda-forge-admin, please restart ci

recipe/meta.yaml Show resolved Hide resolved
@oliver-sanders oliver-sanders marked this pull request as ready for review August 3, 2021 09:48
@oliver-sanders
Copy link
Contributor Author

@conda-forge-admin, please rerender

@oliver-sanders oliver-sanders changed the title collected changes to merge with 8.0b2 release branch 8.0b2 release Aug 3, 2021
@kinow
Copy link
Member

kinow commented Aug 3, 2021

Huh, dependency issues. I think I've had an issue like that. You should be able to build the recipe locally with a similar environment as conda and see what's causing the issue (I think there's a command to get conda to point to what appears to be broken).

@oliver-sanders
Copy link
Contributor Author

oliver-sanders commented Aug 3, 2021

Lots of conflict there, hard to tell the root cause(s), guesses:

  • rx, mentioned in one conflict line, not a Cylc dep, has been an issue in the past.
    • Can we remove the rx dep?
  • PyPy, we would expect problems installing all deps with PyPy (Pandas can be a problem)
    • The build says cPython, however, the log says PyPy
    • It seems to have tried PyPy 3.6 which would never work anyway (we are 3.7+).
    • Can we disable PyPy builds?
    • Would this just cause failures in the other cylc-* feedstocks?
    • I tried setting up testing on cylc-flow to enable us to claim PyPy support, however, installing extra deps (namely Pandas) is problematic.

@kinow
Copy link
Member

kinow commented Aug 3, 2021

Reproduced the issue locally with:

# activate conda
conda install conda-build
conda create -n test-cylc-flow
# debug really slows it down
conda build --use-local -c conda-forge --no-force-upload --debug --no-anaconda-upload ./recipe/

Will re-read your comment and try to understand what's going on in the morning 👍

@oliver-sanders
Copy link
Contributor Author

oliver-sanders commented Aug 3, 2021

Some of the conda-environment deps were pinned incorrectly - cylc/cylc-flow#4340

That pandas<0.26 dep was particularly troublesome.

Currently trying out this diff:

diff --git a/recipe/meta.yaml b/recipe/meta.yaml
index 256515c..f911440 100644
--- a/recipe/meta.yaml
+++ b/recipe/meta.yaml
@@ -21,7 +21,7 @@ requirements:
   run:
     - aiofiles >=0.7.0,<0.8.0
     - ansimarkup >=1.0.0
-    - colorama >=0.4,<0.5
+    - colorama >=0.4,<1.0
     - graphene >=2.1,<3
     - jinja2 ==2.11.0,<2.12
     - metomi-isodatetime >=1!2.0.2, <1!2.1.0
@@ -31,13 +31,12 @@ requirements:
     - pyuv >=1.4.0,<1.5.0
     - pyzmq >=19.0.0,<19.1.0
     - setuptools >=49
-    - urwid >=2.0,<2.1
+    - urwid >=2,<3
     # TODO: optional dependencies, see discussion here https://github.com/conda-forge/cylc-flow-feedstock/pull/4
     - empy >=3.3,<3.4
-    - pandas >=0.25.0,<0.26
+    - pandas >=1.0
     - pympler
     - matplotlib-base
-    - rx >=1.6,<2 # TODO: https://github.com/conda-forge/cylc-feedstock/pull/3#issuecomment-660716268
 
 test:
   imports:

* update conda-forge deps to match setuptools deps
* remove rx dep
@oliver-sanders
Copy link
Contributor Author

That got it.

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks @oliver-sanders !

@hjoliver hjoliver merged commit 8f41bf2 into conda-forge:master Aug 3, 2021
@oliver-sanders oliver-sanders deleted the 8.0b2 branch August 4, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants