Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cylc-flow v8.0b3 #29

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Nov 10, 2021

It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
    Checklist before merging this PR:
  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1446328892, please use this URL for debugging

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis of the source code shows a discrepancy between the library's imports and the package's stated requirements in the meta.yaml.

Packages found by inspection but not in the meta.yaml:

  • rx
  • promise
  • graphql-core

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@oliver-sanders oliver-sanders self-assigned this Nov 11, 2021
@oliver-sanders
Copy link
Contributor

Can't conda build locally due to the placehold_placehold_placehold issue...

recipe/meta.yaml Outdated Show resolved Hide resolved
@oliver-sanders
Copy link
Contributor

Hmm, same issue

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=409266&view=logs&j=4f922444-fdfe-5dcf-b824-02f86439ef14&t=b2a8456a-fb11-5506-ca32-5ccd32538dc0&l=1105

Might try explicitly adding Python to the cylc-flow recipe rather than relying on the pin_subpackge...

@oliver-sanders
Copy link
Contributor

I think I can fix this by swapping {{ PYTHON }} with python for the build script in line with some other examples.

@oliver-sanders
Copy link
Contributor

Attempt 2...

@oliver-sanders
Copy link
Contributor

oliver-sanders commented Nov 11, 2021

Right, that should do it.

We now have two "outputs":

  • The "default" cylc-flow which contains everything except the main loop plugins and test dependencies.
  • The cylc-flow-base output which just contains the bare minimum.

We can add any number of outputs later as desired. For an example of this approach in the wild see JupyterHub.

See cylc/cylc-admin#130

@kinow: Don't know whether you want to continue as a maintainer, feel free to drop out if you don't fancy the admin! I can't work out how to change that though it might be as simple as editing the maintainer list? Dunno.

@hjoliver
Copy link
Contributor

@kinow: Don't know whether you want to continue as a maintainer, feel free to drop out if you don't fancy the admin! I can't work out how to change that though it might be as simple as editing the maintainer list? Dunno.

See #28

* Update dependencies.
* Update metadata.
* Split package into `cylc-flow-base` (required deps only)
  and `cylc-flow` (all optional deps).
@oliver-sanders
Copy link
Contributor

Lets do #28 later, I'll post on their gitter for instructions.

Copy link
Contributor

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as per instructions in cylc/cylc-admin#133. cylc play and cylc clean both working

@oliver-sanders
Copy link
Contributor

@hjoliver Best delay merging this one whilst we sort out the others.

If you're happy with the outputs change I'll go ahead and push up cylc-uiserver and cylc-rose alternatives.

@hjoliver
Copy link
Contributor

Yes, happy with the outputs change 👍

@oliver-sanders
Copy link
Contributor

Built the package locally, the outputs seemed to be working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants