Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows compilation #6

Merged
merged 8 commits into from
Mar 19, 2021
Merged

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Mar 13, 2021

Add Windows support by backporting the dartsim/dart#1541 to 6.9 releases.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@traversaro traversaro requested a review from wolfv as a code owner March 13, 2021 15:03
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro traversaro changed the title Add Windows compilation [WIP] Add Windows compilation Mar 13, 2021
@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro traversaro changed the title [WIP] Add Windows compilation Add Windows compilation Mar 19, 2021
@traversaro
Copy link
Contributor Author

Backport of dartsim/dart#1541 and dartsim/dart#1542 worked fine, PR is ready for review to be merged. fyi @wolfv @Tobias-Fischer

@Tobias-Fischer
Copy link
Contributor

LGTM, thanks!

@traversaro traversaro merged commit 2b8d3b6 into conda-forge:master Mar 19, 2021
@traversaro traversaro deleted the add-win branch March 19, 2021 09:33
@wolfv
Copy link
Member

wolfv commented Mar 19, 2021

the only comment I have is that this builds a static lib on Windows, but I think that's fine (especially if it would be difficult to turn on dll compilation).

@wolfv
Copy link
Member

wolfv commented Mar 19, 2021

awesome stuff, btw!

@traversaro
Copy link
Contributor Author

the only comment I have is that this builds a static lib on Windows, but I think that's fine (especially if it would be difficult to turn on dll compilation).

Yes, upstream issue: dartsim/dart#1501 .

@wolfv
Copy link
Member

wolfv commented Mar 19, 2021

Alright. very cool, the robotics ecosystem on conda-forge is really growing a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants