-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows compilation #6
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…da-forge-pinning 2021.03.13.12.09.21
Backport of dartsim/dart#1541 and dartsim/dart#1542 worked fine, PR is ready for review to be merged. fyi @wolfv @Tobias-Fischer |
LGTM, thanks! |
the only comment I have is that this builds a static lib on Windows, but I think that's fine (especially if it would be difficult to turn on dll compilation). |
awesome stuff, btw! |
Yes, upstream issue: dartsim/dart#1501 . |
Alright. very cool, the robotics ecosystem on conda-forge is really growing a lot. |
Add Windows support by backporting the dartsim/dart#1541 to 6.9 releases.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)