Enable test_Collision on Linux/macOS #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.03.16.08.53.10
|
Great, this fails, with output: And what fails is a test related to |
|
Indeed, there are some prints related to this: that links an issue that is still open in FCL: flexible-collision-library/fcl#106 . Perhaps we should change some setting of which collision handler to use? Even if as far as I know we are not changing anything. |
|
Interestingly, the same tests seems to have been disabled upstream: dartsim/dart@a6f8a94 . |
This was referenced Mar 16, 2024
|
I modified the test to run locally and to be explicit w.r.t. to which collision detector is failing the test, and indeed it turns out that the problem is with the ODE collision detector, that is the one used by default in gz-physics/gz-sim. I have renamed the title of #39 to be more explicit on the problem that the issue is tracking. |
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was not passing and not merged. |
|
Great, now all the failures on Linux/macOS are done, we anyhow still have a Windows failure that anyhow is different from previous failures: Not sure if this is related to ODE or not. |
|
Perhaps related: dartsim/dart#876 . |
|
Hi! This is the friendly conda-forge automerge bot! Commits were made to this PR after the |
1 task
traversaro
changed the title
I opened #63 to track this. In the meanwhile we can at least enable the collision test on Linux/macOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #39 . This was triggered by conda-forge/gz-physics-feedstock#24 (comment), even if I do not know how much the two problems are related.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)