-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.1.3: fixed missing deps and improve test #29
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@@ -44,6 +44,7 @@ requirements: | |||
- xmltodict | |||
- imagecodecs | |||
- albumentations | |||
- setuptools <59.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- due to AttributeError: module 'distutils' has no attribute 'version' : with setuptools 59.6.0 pytorch/pytorch#69894
- remove this version constraint after pytorch 1.10.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I need to understand the status. Locally @ethanwhite was having trouble building. But I see tests pass on CI for linux.
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=442980&view=results
passes. What error is this PR trying to fix?
This PR primarily addresses the missing albumentations dependency. Generally I think we're up and running otherwise - see additional discussion in weecology/DeepForest#288 this morning. Builds are still finicky but there are ways to do it consistently. There was also some sort of lag somewhere in the pipeline which cleaned itself up overnight (conda stopped trying to install 0.2.x). |
the CI passed before, because it run only you can review if the version constraint makes sense.. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)