Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.1.3: fixed missing deps and improve test #29

Merged
merged 3 commits into from
Jan 19, 2022
Merged

v1.1.3: fixed missing deps and improve test #29

merged 3 commits into from
Jan 19, 2022

Conversation

easz
Copy link

@easz easz commented Jan 19, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@@ -44,6 +44,7 @@ requirements:
- xmltodict
- imagecodecs
- albumentations
- setuptools <59.6.0
Copy link
Author

@easz easz Jan 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@bw4sz bw4sz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I need to understand the status. Locally @ethanwhite was having trouble building. But I see tests pass on CI for linux.

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=442980&view=results

passes. What error is this PR trying to fix?

@ethanwhite
Copy link
Contributor

This PR primarily addresses the missing albumentations dependency.

Generally I think we're up and running otherwise - see additional discussion in weecology/DeepForest#288 this morning. Builds are still finicky but there are ways to do it consistently. There was also some sort of lag somewhere in the pipeline which cleaned itself up overnight (conda stopped trying to install 0.2.x).

@easz
Copy link
Author

easz commented Jan 19, 2022

the CI passed before, because it run only import deepforest as the single test.
It would fail with running from deepforest import main...
therefore I added the missing dependency, defined some version constraint and added a "test" in meta.yml.

you can review if the version constraint makes sense..

@bw4sz bw4sz merged commit fa8bc9b into conda-forge:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants