-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add run_exports #11
Add run_exports #11
Conversation
Since fmt is a shared library, we should tell every recipe that builds against it to require a compatible version at runtime.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender. |
…nda-forge-pinning 2020.03.24
fmt seems to be quite strict about ABI compatibility, see fmtlib/fmt#1471.
Thanks for the PR. This feature is new to me. Can you argue what this solves? I always thought that any package that builds against this library should just include the library (and optionally the version) in the dependencies. A second question is that if this is necessary, shouldn't it be done here https://github.com/conda-forge/conda-forge-pinning-feedstock ? |
@conda-forge-admin, please rerender. |
…nda-forge-pinning 2020.04.09
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
Sorry for the late reply.
I believe that it used to be like that before this feature was available. This makes every package that has fmt in
This is not the recommended way of doing things anymore: conda-forge/conda-forge-pinning-feedstock#503 (review) |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I finally sort of clarified the questions I was having. It seems that both this PR, as well as conda-forge/conda-forge-pinning-feedstock#503 should be merged to get proper pinning. |
Since fmt is a shared library, we should tell every recipe that builds against it to require a compatible version at runtime.