Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run_exports #11

Merged
merged 5 commits into from
Apr 11, 2020
Merged

Add run_exports #11

merged 5 commits into from
Apr 11, 2020

Conversation

saraedum
Copy link
Member

Since fmt is a shared library, we should tell every recipe that builds against it to require a compatible version at runtime.

Since fmt is a shared library, we should tell every recipe that builds against it to require a compatible version at runtime.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@saraedum
Copy link
Member Author

@conda-forge-admin, please rerender.

conda-forge-linter and others added 2 commits March 26, 2020 06:03
fmt seems to be quite strict about ABI compatibility, see fmtlib/fmt#1471.
@tdegeus
Copy link
Member

tdegeus commented Mar 26, 2020

Thanks for the PR.

This feature is new to me. Can you argue what this solves? I always thought that any package that builds against this library should just include the library (and optionally the version) in the dependencies. A second question is that if this is necessary, shouldn't it be done here https://github.com/conda-forge/conda-forge-pinning-feedstock ?

@saraedum
Copy link
Member Author

saraedum commented Apr 9, 2020

@conda-forge-admin, please rerender.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@saraedum
Copy link
Member Author

saraedum commented Apr 9, 2020

Sorry for the late reply.

I always thought that any package that builds against this library should just include the library (and optionally the version) in the dependencies.

I believe that it used to be like that before this feature was available. This makes every package that has fmt in host have a compatible version in run.

A second question is that if this is necessary, shouldn't it be done here conda-forge/conda-forge-pinning-feedstock ?

This is not the recommended way of doing things anymore: conda-forge/conda-forge-pinning-feedstock#503 (review)

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@tdegeus
Copy link
Member

tdegeus commented Apr 11, 2020

I finally sort of clarified the questions I was having. It seems that both this PR, as well as conda-forge/conda-forge-pinning-feedstock#503 should be merged to get proper pinning.

@tdegeus tdegeus merged commit 211d870 into conda-forge:master Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants