Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup build for MacOSX #11

Closed
wants to merge 8 commits into from
Closed

Conversation

sharanry
Copy link

@sharanry sharanry commented Feb 14, 2018

Tries to fix #1901

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@souravsingh
Copy link
Contributor

@sharanry For Gensim to support Mac OS X, you will need to plugin Travis, since conda-forge uses different CI builds for different platforms. If you can figure out how to get Travis working without timeout, that would be awesome.

@sharanry
Copy link
Author

@souravsingh Thanks for the guidance.
I saw that you tried to fix this in an earlier test PR, was Travis's timeout the only problem?

@souravsingh
Copy link
Contributor

@sharanry Indeed. The Travis times out when running the doc2vec tests.

@sharanry
Copy link
Author

@souravsingh If resource constraints are cause of the time out, this might be the solution.

@souravsingh
Copy link
Contributor

Limit Concurrent Jobs is off for the conda-forge builds.

@sharanry
Copy link
Author

sharanry commented Feb 14, 2018

Limit Concurrent Jobs is off for the conda-forge builds.

Shouldn't it be tuned on and fixed to 1?
and if that doesn't work here is a work around.

@souravsingh
Copy link
Contributor

souravsingh commented Feb 14, 2018

It is not recommended by conda-forge to edit the Travis YAML files

@souravsingh
Copy link
Contributor

The builds are failing for Appveyor and Travis. I would suggest to close and reopen again to restart the CI services.

@menshikh-iv
Copy link
Member

Hi guys @sharanry @souravsingh, how is going? What's a problem right now?

@menshikh-iv
Copy link
Member

@sharanry changed permissions of some files looks very suspicious, why this needed?

@sharanry
Copy link
Author

changed permissions of some files looks very suspicious, why this needed?

This was done automatically by conda-smithy, however i manually removed those changes now

@menshikh-iv
Copy link
Member

@sahmed95 some tips for you:

  • try to run MacOSX with the different testing system (default unittest or pytest).
  • check that file compiled correctly (looks OK in logs, but better to manually check it)

@isuruf
Copy link
Member

isuruf commented Feb 15, 2018

If a test timeouts, then you can disable that test by giving --exclude REGEX to nosetests.

@menshikh-iv
Copy link
Member

@isuruf thanks for the suggestion, but if test timeouts, this is the really suspicious situation, need to investigate the problem (but not ignore it).

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [64]

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@sharanry
Copy link
Author

Test doc2vec parallel training is the one taking too long in macos

@souravsingh
Copy link
Contributor

@sharanry Yup, that's the one that causes the timeout. And we cannot skip it since it is an important test.

@sharanry
Copy link
Author

@sharanry Yup, that's the one that causes the timeout. And we cannot skip it since it is an important test.

Trying to run tests using pytest on travis ci

@souravsingh
Copy link
Contributor

There is a mistake in the pytest command.

@menshikh-iv
Copy link
Member

@sharanry this is really important feature for gensim, please focus on it

@gyanesh-m
Copy link

gyanesh-m commented Feb 26, 2018

@sharanry @souravsingh Hi, I would also like to help. Travis-ci log for py3.5 and py3.6 shows that the build failed with error "loader for pytest cannot handle py.test". It looks like a similar problem as here.

@menshikh-iv menshikh-iv mentioned this pull request Sep 22, 2018
@menshikh-iv
Copy link
Member

outdated, closing

@menshikh-iv menshikh-iv closed this Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add anaconda-cloud badge & setup build for MacOSX
6 participants