-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for protobuf423 #9
Rebuild for protobuf423 #9
Conversation
…nda-forge-pinning 2023.05.24.18.03.31
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
The build fails with:
I need to check this in detail, but my intuition is that the new protobuf 4.23 added a depedency on abseil in the public headers, so it is necessary that all downstream users of protobuf link abseil. However, CMake's Possible solutions:
with the additional abseil dependency we now need to make sure that all compilation units are compiled with the same version of C++ used to compile abseil. Unfortunatly, CMake is not equipped to do this check automatically (see https://gitlab.kitware.com/cmake/cmake/-/issues/22592 and abseil/abseil-cpp#259). |
Actually the Protobuf gz-cmake machinery actually looks first for the protobuf with CONFIG, see https://github.com/gazebosim/gz-cmake/blob/d618dd70c0862d8e6c9ee9aa6d776bc30bf2f19c/cmake/FindGzProtobuf.cmake#L29 . However, that is failing (and hence falling back to the FindProtobuf cmake script) with error:
|
The reason is https://github.com/gazebosim/gz-msgs/blob/460d563c6437731e3c89df2342228a1889390902/CMakeLists.txt#L85 . Basically we pass As the only Ubuntu distribution with protobuf 2 is Ubuntu 16.04 (in EOL since a long time ago), I guess we can just drop the requirement. |
Cross-compilation is now failing on osx-arm64:
|
From what I understand, the trick of passing the Protobuf_PROTOC_EXECUTABLE variable does not work anymore, either because it never worked with |
I think the latter is the case, see: |
Superseded by #10 . |
This PR has been triggered in an effort to update protobuf423.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5074214674, please use this URL for debugging.