-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
post-link actions are missing but required (by upstream) #31
Comments
Note that even the maintainers of ipywidgets relied on this fact: https://github.com/jupyter-widgets/ipywidgets#install |
cc @gph82 |
The issue you link above is a problem in the nglview feedstock, not this one. The nglview feedstock should not be a noarch feedstock. |
@jasongrout ideally we should not need to do the post-install. I am not convinced to require user to do that. Hopefully notebook folks can have better solution. |
Chiming in here as well to say @jasongrout is correct. If you are wanting to use |
Agreed (we've all suffered because of this), but that's how the current notebook extension system works. The conversation about a better notebook extension system is over at jupyter/notebook#1706. |
Let's move the discussion about getting nglview working over to conda-forge/nglview-feedstock#5, and the discussion about the notebook extension system (especially if someone wants to work on it!) over to jupyter/notebook#1706. |
Just to be clear for @marscher - no change is needed to this ipywidgets feedstock. The thing that broke the nglview installation was moving it to a noarch package, since noarch packages do not execute post-link scripts. And as @jakirkham pointed out, getting noarch packages to work with post-install scripts is a feature request for conda/conda-build. |
I have retested with a local build without noarch and still there are no enabled notebook extensions available (py27, will redo with py36). Have you taken a look at the official documentation? The devs there are requiring conda-forge to handle the extensions activation, which is currently not the case. |
Hi @marscher |
Hi Maarten,
then I wonder why their extensions are not enabled. But I should report there I'd guess.
Best,
Martin
|
Try with a new conda env, if you install for instance bqplot or ipyvolume (from conda forge), you should see widgetsnbextensions being installed, and enabled if you do |
thanks, will do so.
|
@maartenbreddels brings up a good point about channels - our conversation here is about the conda-forge widgetsnbextension, which we maintain. The defaults channel widgetsnbextension package does things a different way. Make sure you're installing the conda-forge channel version for our conversation here. |
I wrongly named the post/prelink scripts in the nglview feedstock. But even with nglview extension enabled properly the widgets do not show up. It is for sure not an upstream problem. Sorry for causing so much noise! |
Ah, that would do it too. |
similar to widgetsnbextension, which installs and registers the javascript parts of the widgets in the local installation, we need to this for this package as well. in #3 someone stated that is is sufficient to only depend on widgetsnbextension for this purpose, but this does not hold true (any more).
https://github.com/conda-forge/widgetsnbextension-feedstock/blob/master/recipe/post-link.sh
People are getting problems with widgets because they are not installed fully (eg. installed python pkg, javascript extension installed and registered).
cc conda-forge/nglview-feedstock#5
The text was updated successfully, but these errors were encountered: