Updated to 5.0.0 #3

ocefpaf · 2016-04-20T11:32:14Z

Changed from PyPI to GitHub and using sha256 instead of md5.

conda-forge-linter · 2016-04-20T11:32:16Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

pelson · 2016-04-20T11:52:50Z

Before merging this, it would be helpful to get some oversight from the @jdfreder. Is there an additional dependency which we should be pulling in (e.g. was the JS pulled out of this package and into widgetsnbextension).

jdfreder · 2016-04-22T16:20:11Z

@pelson yeah, part of the Javascript was published to npm. The widgetsnbextension package installs that part and adds to it. The built (combined) static assets are a resource of the widgetsnbextension package (you can see this is the contents uploaded to pypi). Installing ipywidgets should automatically install widgetsnbextension. In order for the widgets to work in the notebook (only compatible with the newly released 4.2), jupyter nbextension enable --py widgetnbextension must be ran. cc. @SylvainCorlay

jakirkham · 2016-04-26T14:03:04Z

So, let me try to reduce this. Please correct me if I'm wrong.

PyPI has all the Javascript code included.
No new dependencies are required.
Installation requires a second step (jupyter nbextension enable --py widgetnbextension).

jdfreder · 2016-04-26T15:45:41Z

Yes to 1 and 3, no to 2. ipywidgets is required as it was before and additionally widgetsnbextension is required.

jakirkham · 2016-04-26T15:49:00Z

Hmm...I thought that widgetsnbextension was already included, no?

jakirkham · 2016-04-26T15:50:20Z

FWIW, AppVeyor already passed, but the status didn't update for some reason.

jdfreder · 2016-04-26T23:04:22Z

widgetsnbextension is new to ipywidgets 5.0. It is a dependency of ipywidgets, maybe that's what you mean by included.

pelson · 2016-04-27T15:38:49Z

We need a new conda-forge feedstock called widgetsnbextension, and to add that as a dependency here AFAICT. It would also be nice if we had a test in this feedstock which failed without that dependency.

ocefpaf · 2016-04-27T15:49:49Z

We need a new conda-forge feedstock called widgetsnbextension

I have a PR almost ready for that. I was just waiting for the CircleCI issues to be resolved. I am sending it soon.

jakirkham · 2016-04-27T16:07:33Z

I have a PR almost ready for that. I was just waiting for the CircleCI issues to be resolved. I am sending it soon.

Feel free to send it when you are ready. I don't know what timescale these CircleCI API issues will be resolved. If we need it really badly, we can just restart Travis loads of times until it works. Not optimal, but that is sort of the situation until CircleCI gets back to us.

jakirkham · 2016-04-27T16:07:53Z

NVM guess you just did.

jakirkham · 2016-04-28T04:54:02Z

This needs to be re-rendered with conda-smithy built with this commit ( conda-forge/conda-smithy@41e300e ).

jakirkham · 2016-04-28T06:28:55Z

There is now a feedstock for widgetsnbextension and packages have been released for all OSes, Python versions, and architectures.

ocefpaf · 2016-04-28T11:51:24Z

@pelson not sure if this build is 100% test to ensure we can close #1

I appreciate if someone more knowledgeable of ipywidgets could take a look.

pelson · 2016-04-28T15:29:54Z

recipe/meta.yaml


 test:
  imports:
    - ipywidgets

 about:
-  home: http://github.com/jakevdp/ipywidgets


😆 - how did that happen! 😄

Well, he did have something like that once. ( http://github.com/jakevdp/ipywidgets-static )

pelson · 2016-04-28T15:31:09Z

This is good to go. Thanks @ocefpaf!
@jdfreder - do you have a way of testing that the widgetsnbextension is available (I guess we could always just try importing it).

parente · 2016-05-01T00:03:29Z

ipywidgets is now at version 5.1.2 to fix some bugs an API incompatibilities. And widgetsnbextension is at 1.2.1. Does it make sense to go to 5.0.0 first and then bump again or just update this PR?

jakirkham · 2016-05-01T00:09:32Z

Nice to see you over here, @parente. At this point, I'm thinking conda-forge is the only way to keep up with Jupyter's rapid releases in any realistic way. I wonder if it would be worthwhile to start adding conda-forge as a channel in the docker images so that we can ensure we are getting the newest packages available.

Sure, that's fine. Right now I think we are waiting for some feedback from, @jdfreder. There was some concern that ipywidgets was not getting installed and configured correctly before and we would like to know if we are on the mark now or if there is more we need to fix before merging this. Related, we would like to have some test to ensure we are now installing it correct and will continue to be in future releases.

parente · 2016-05-01T00:14:40Z

I wonder if it would be worthwhile to start adding conda-forge as a channel in the docker images so that we can ensure we are getting the newest packages available.

@minrk added it yesterday to docker-stacks and @willingc merged. I don't think a build was kicked off though.

Sure, that's fine. Right now I think we are waiting for some feedback from, @jdfreder.

Understood. Just a friendly FYI on the versions.

ocefpaf · 2016-05-01T00:14:42Z

Does it make sense to go to 5.0.0 first and then bump again or just update this PR?

I would just update the PR. Oh wait! I am the author of the PR 😳

Let me get to it...

jakirkham · 2016-05-01T00:18:45Z

@minrk added it yesterday to docker-stacks and @willingc merged. I don't think a build was kicked off though.

Awesome!

Sorry, I may have missed it. My notifications are literally swamped with stuff from here. Still trying to figure out how best to handle that better.

Understood. Just a friendly FYI on the versions.

Sure and we appreciate the FYI.

SylvainCorlay · 2016-05-01T00:20:56Z

We will probably make minor bug-fix releases of ipywidgets and
widgetsnbextension quite often from now on.

IMO there are only benefits to updating the PR.
On Apr 30, 2016 8:18 PM, "jakirkham" [email protected] wrote:

@minrk https://github.com/minrk added it yesterday to docker-stacks and
@willingc https://github.com/willingc merged. I don't think a build was
kicked off though.

Awesome!

Sorry, I may have missed it. My notifications are literally swamped with
stuff from here. Still trying to figure out how best to handle that better.

Understood. Just a friendly FYI on the versions.

Sure and we appreciate the FYI.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#3 (comment)

ocefpaf · 2016-05-01T18:13:41Z

@ocefpaf Sure 😄

Done! Welcome to conda-forge!!

bollwyvl · 2016-05-02T14:42:57Z

appveyor.yml

@@ -59,10 +59,15 @@ install:
    - cmd: set PATH=%CONDA_INSTALL_LOCN%;%CONDA_INSTALL_LOCN%\scripts;%PATH%
    - cmd: set PYTHONUNBUFFERED=1

+    - cmd: conda config --set show_channel_urls true
    - cmd: conda install -c http://conda.binstar.org/pelson/channel/development --yes --quiet obvious-ci
    - cmd: conda config --add channels http://conda.binstar.org/conda-forge
    - cmd: conda info
    - cmd: conda install -n root --quiet --yes conda-build anaconda-client jinja2 setuptools


Also pin the version of conda-build, as in .travis.yml?

Ah, I see the line below!

bollwyvl · 2016-05-02T14:54:20Z

Also, would be curious to get @bollwyvl's feedback on this change to ipywidgets.

@jakirkham what are you looking for in particular?

I reviewed and didn't see anything out of place, other than my failure to read re: pinning conda-build!

Raised a question over here about the installation procedure for the user:
conda-forge/widgetsnbextension-feedstock#4

parente · 2016-05-02T16:35:24Z

@ocefpaf said:

@SylvainCorlay, @parente, and @willingc would you be willing to be added as maintainers of this recipe? If so I can do that in this PR for you.

I'm not an ipywidgets expert by any means, so I think you're better off keeping me on the list of people who send PRs instead of people with the ability to merge and break master. 🙈

jakirkham · 2016-05-02T16:37:40Z

If you ( @parente ) are interested in helping maintain the docker image though, we would be more than happy to have you on board there. Though it is substantially simpler than the ones at docker-stacks. Mainly this determines how builds are done on the Linux side of things here.

SylvainCorlay · 2016-05-02T16:38:53Z

I'm not an ipywidgets expert by any means, so I think you're better off keeping me on the list of people who send PRs instead of people with the ability to merge and break master. 🙈

@parente is totally an ipywidgets expert.

jakirkham · 2016-05-02T16:39:39Z

Ah so he's being humble here. 😉

jakirkham · 2016-05-02T16:54:16Z

@jakirkham what are you looking for in particular?

Well @bollwyvl, I remember you had mentioned spending a fair bit of time trying to get these to install properly and I wanted to make sure that the installation we are doing here and with widgetsnbextension looked reasonable. Also, if there are any thoughts you have on good tests, we would appreciate hearing them so that we can verify this continues to work in the future.

SylvainCorlay · 2016-05-03T01:29:33Z

recipe/meta.yaml

@@ -1,17 +1,17 @@
-{% set version = "4.1.1" %}
+{% set version = "5.1.2" %}


Can you point to 5.1.3, I just made a patch release?

Done! Thanks @SylvainCorlay!

SylvainCorlay · 2016-05-04T10:55:00Z

This looks good to me. Should we get this in?

bollwyvl · 2016-05-04T13:31:36Z

Also, if there are any thoughts you have on good tests, we would appreciate hearing them so that we can verify this continues to work in the future.

Yeah, that's the rub!

On many of our extensions, I am using the somewhat-creaky PhantomJS/CasperJS test stuff that the 4.x notebook uses. It looks like widgets is now on the karma side of things, which I haven't been able to use, as anaconda.org doesn't have native browsers (coming soon, I'm promised)... and if using phantom (even 2.x), would inherit all the same old nasty problems. But it does seem the way of justice.

Assuming we don't have browsers, I guess the best one could do would be to see if the extensions actually installed correctly (i.e. check the output of jupyter (server|nb)extension for errors).

Sorry, going a bit off topic here...

At the Jupyter Dev meeting, we talked about extracting the good bits of jupyter-js-notebook's tests into something that a developer could use at test time to easily employ best practices for testing extension-related functionality in as close to a representative environment as possible. Since this will inevitably use node stuff, conda is a great target, as you can now just pull nodejs off the defaults channel... or use the conda-forge one! We've talked a bit about making common web tool chains installable directly as conda packages, which would be wonderful for cutting down on build times.

It should be possible for a dev to specify:

really robust config for the server startup, good logging, etc.
notebooks that should have expected output, a la nosebook
simple js features
easy mocks of "fancy things"
screenshots of test steps
- 🍰 posting (anonymous gist?) of a notebook test report with said screenshots embedded!

SylvainCorlay · 2016-05-04T15:54:04Z

recipe/meta.yaml


 test:
  imports:
    - ipywidgets

 about:
-  home: http://github.com/jakevdp/ipywidgets
+  home: https://github.com/ipython/ipywidgets
  license: BSD 3-clause
  summary: IPython Static Widgets


Should this rather be Jupyter interactive widgets

The GitHub pages has: IPython widgets for the Jupyter Notebook I am changing here to Widgets for the Jupyter Notebook, sounds good?

As long as they aren't "static" and it's referring to "Jupyter", I'm happy. @SylvainCorlay comments?

The front-end is now kernel-language agnostic and we are working hard to make it work outside of the notebook....

SylvainCorlay · 2016-05-04T15:54:35Z

I am 👍 on merging this and iterating from there...

SylvainCorlay · 2016-05-04T15:54:59Z

(I will depend on this for the recipes on ipyleaflet, bqplot, pythreejs...)

jakirkham · 2016-05-04T15:58:12Z

I see @bollwyvl. Thanks for the useful feedback. Can we maybe add an issue wrt to testing and we will table it for now?

If people are happy with this as is, I'm eager to see it go in ASAP.

jakirkham · 2016-05-04T17:10:24Z

There was a failure downloading miniconda in one of the Travis CI builds. As this is unrelated to the content here, I went ahead and restarted it.

SylvainCorlay · 2016-05-05T14:41:26Z

Merge?

jakirkham · 2016-05-05T14:42:27Z

Agreed.

jakirkham · 2016-05-05T14:43:00Z

Thanks everyone. If we have new issues, let's iterate. Sound good?

pelson · 2016-05-06T20:31:43Z

I guess the best one could do would be to see if the extensions actually installed correctly (i.e. check the output of jupyter (server|nb)extension for errors).

This is an excellent suggestion, I'd love to see this in the recipe!

Great to have you guys on board with this recipe - welcome! There are details here that only somebody in the thick of development can know so it is awesome to be able to pull on that knowledge to package ipywidgets (& friends) to give conda users the best possible experience.

Updated to 5.0.0

87ef198

Fix home URL

a33dfb7

ocefpaf added 3 commits April 28, 2016 08:40

rerender

f1ba8e5

Add widgetsnbextension

5ddee31

Update to 5.1.0

6fd0302

pelson reviewed Apr 28, 2016
View reviewed changes

ocefpaf added 2 commits April 30, 2016 21:19

Re-render

248bbf8

Updated to 5.1.2

017a65a

Add willingc

8526543

bollwyvl reviewed May 2, 2016
View reviewed changes

SylvainCorlay reviewed May 3, 2016
View reviewed changes

Update to 5.1.3

e432905

ocefpaf mentioned this pull request May 3, 2016

Python install line standard conda-forge/staged-recipes#528

Closed

SylvainCorlay reviewed May 4, 2016
View reviewed changes

Update summary

f7a92b0

SylvainCorlay mentioned this pull request May 5, 2016

Run ipywidgets tests on build of the feedstock #4

Closed

jakirkham merged commit 7113b31 into conda-forge:master May 5, 2016

ocefpaf deleted the bump branch May 5, 2016 14:44

marscher mentioned this pull request Nov 30, 2017

post-link actions are missing but required (by upstream) #31

Closed

		@@ -1,17 +1,17 @@
		{% set version = "4.1.1" %}
		{% set version = "5.1.2" %}

Updated to 5.0.0 #3

Updated to 5.0.0 #3

Conversation

ocefpaf commented Apr 20, 2016

conda-forge-linter commented Apr 20, 2016

pelson commented Apr 20, 2016 • edited Loading

jdfreder commented Apr 22, 2016 • edited Loading

jakirkham commented Apr 26, 2016 • edited Loading

jdfreder commented Apr 26, 2016

jakirkham commented Apr 26, 2016

jakirkham commented Apr 26, 2016

jdfreder commented Apr 26, 2016 • edited Loading

pelson commented Apr 27, 2016

ocefpaf commented Apr 27, 2016

jakirkham commented Apr 27, 2016

jakirkham commented Apr 27, 2016 • edited Loading

jakirkham commented Apr 28, 2016 • edited Loading

jakirkham commented Apr 28, 2016

ocefpaf commented Apr 28, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pelson commented Apr 28, 2016

parente commented May 1, 2016

jakirkham commented May 1, 2016

parente commented May 1, 2016

ocefpaf commented May 1, 2016

jakirkham commented May 1, 2016

SylvainCorlay commented May 1, 2016

ocefpaf commented May 1, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bollwyvl commented May 2, 2016

parente commented May 2, 2016

jakirkham commented May 2, 2016

SylvainCorlay commented May 2, 2016

jakirkham commented May 2, 2016

jakirkham commented May 2, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SylvainCorlay commented May 4, 2016

bollwyvl commented May 4, 2016

SylvainCorlay May 4, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SylvainCorlay commented May 4, 2016

SylvainCorlay commented May 4, 2016

jakirkham commented May 4, 2016

jakirkham commented May 4, 2016

SylvainCorlay commented May 5, 2016

jakirkham commented May 5, 2016

jakirkham commented May 5, 2016

pelson commented May 6, 2016

pelson commented Apr 20, 2016 •

edited

Loading

jdfreder commented Apr 22, 2016 •

edited

Loading

jakirkham commented Apr 26, 2016 •

edited

Loading

jdfreder commented Apr 26, 2016 •

edited

Loading

jakirkham commented Apr 27, 2016 •

edited

Loading

jakirkham commented Apr 28, 2016 •

edited

Loading

SylvainCorlay May 4, 2016 •

edited

Loading