julia v1.9.0 #245
Merged
julia v1.9.0 #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nda-forge-pinning 2023.05.06.16.29.06
regro-cf-autotick-bot
requested review from
SylvainCorlay,
abhi18av,
acaprez,
bgruening,
dfornika,
mariusvniekerk,
mkitti and
ngam
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Weird, it says the following. Maybe this is a basic fix? @ngam @mkitti |
|
We would need to rework the patch. I will do it this weekend. |
|
|
@mkitti are you aware of any substantial changes to the build system upstream? error...
|
|
@conda-forge-admin,please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/julia-feedstock/actions/runs/5063111650. |
|
I have reproduced the issue locally on Linux. Investigating. |
|
Ok, we actually do produce a working build of Julia 1.9. The problem is that the installation gets screwed up somehow. |
|
It's trying to find |
|
The LD_LIBRARY_PATH setting is screwing up julia. In |
|
Okay, what we want to do is point julia to the correct path, then? |
|
Playing with LD_LLIBRARY_PATH is likely not a good solution because a lot of things depend on it in the ecosystem |
LD_DEBUG output
|
|
Julia seems happy if we do not set Why are we setting this in the first place? julia-feedstock/recipe/build.sh Lines 3 to 7 in 41f00ab |
|
Simpler solution: |
|
I'm not entirely sure that I am fixing the same issue that CI is encountering. |
|
I have a local build on Linux. How do I replicate just the test step? |
|
We are getting closer. There are just some test failures with MPFR now |
ngam
reviewed
May 28, 2023
recipe/meta.yaml
Outdated
| @@ -76,7 +75,7 @@ requirements: | |||
| test: | |||
| commands: | |||
| # check out versioninfo | |||
| - julia -e 'using InteractiveUtils; InteractiveUtils.versioninfo()' | |||
| - LD_DEBUG=libs julia -e 'using InteractiveUtils; InteractiveUtils.versioninfo()' | |||
There was a problem hiding this comment.
can we remove LD_DEBUG=libs before merging?
There was a problem hiding this comment.
Yes, but I'm still debugging
|
Something is different between conda-forge's MPFR build and Julia's MPFR build: conda-forge MPFR: Julia MPFR: Somehow the default precision is different for conda-forge uses Yggdrasil uses |
|
Did the tests fail because we ran out of time? |
|
Filed conda-forge/mpfr-feedstock#42 with the mpfr-feedstock |
|
@ngam We could use mpfr 4.1.0. That seems to work fine as far as printing goes. Next build perhaps, if this one works? |
|
@ngam We have green CI on Julia 1.9 |
ngam
approved these changes
May 29, 2023
| if [[ "${target_platform}" == linux-* ]]; then | ||
| rm $PREFIX/lib/julia/{libcholmod.so,libcurl.so} | ||
| fi | ||
|
|
There was a problem hiding this comment.
Is this needed or was it part of debugging?
There was a problem hiding this comment.
We might be able to remove this.
There was a problem hiding this comment.
Ok, we will attempt later.
Let’s get this merged first
recipe/build.sh
Outdated
| # Hack to suppress building docs | ||
| cat > doc/Makefile << EOF | ||
| html : | ||
| mkdir -p _build/html | ||
| EOF | ||
|
|
||
| export PATCHELF_SET_RPATH_ARG="--add-rpath" |
There was a problem hiding this comment.
I added this, but I am not sure if we need it or if we can get rid of it. Thoughts?
| export LIBRARY_PATH=${PREFIX}/lib | ||
| export CMAKE_PREFIX_PATH=${PREFIX} | ||
| export PATH="${PREFIX}/bin:${PATH}" | ||
|
|
There was a problem hiding this comment.
I deleted these, but should we bring them back?
There was a problem hiding this comment.
I think we can leave these out.
|
For MPFR you need to apply JuliaLang/julia#49909 |
|
Looks like it's being backported Julia 1.9.1, so I think we'll catch it then. |
|
@MilesCranmer 1.9.0 should be available shortly in conda-forge |
|
Nice work!! |
|
Stress tested the 1.9.0 binary and everything is looking good! (PySR integration tests: https://github.com/MilesCranmer/PySR/actions/runs/5114058241) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_fileis packagedInformation about this PR:
@conda-forge-admin,please add bot automergein the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
Dependency Analysis
We couldn't run dependency analysis due to an internal error in the bot. :/ Help is very welcome!
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/4912498197, please use this URL for debugging.