Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add build number to blas-devel build string #50

Merged
merged 5 commits into from
Apr 9, 2021

Conversation

minrk
Copy link
Member

@minrk minrk commented Mar 15, 2021

matches all other blas-devel providers in blas-feedstock

Without this, the blas-devel package doesn't get updates but has explicit pins to old builds, making it eventually incompatible with its own newer builds.

cf conda-forge/blas-feedstock#29

ensures blas-devel gets updates when it needs them

which is every rebuild, due to the use of pin_subpackage(exact=True)
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'libblas' output doesn't have any tests.
  • It looks like the 'libcblas' output doesn't have any tests.
  • It looks like the 'liblapack' output doesn't have any tests.
  • It looks like the 'liblapacke' output doesn't have any tests.
  • It looks like the 'blas-devel' output doesn't have any tests.
  • It looks like the 'lapack' output doesn't have any tests.

@minrk
Copy link
Member Author

minrk commented Mar 15, 2021

Failure appears unrelated

@minrk
Copy link
Member Author

minrk commented Mar 17, 2021

mac-arm builds appear to be a compiler problem:

during GIMPLE pass: slp
/Users/runner/miniforge3/conda-bld/blas-split_1615836479051/work/BLAS/SRC/cherk.f:174:22:

  174 |       SUBROUTINE CHERK(UPLO,TRANS,N,K,ALPHA,A,LDA,BETA,C,LDC)
      |                      ^
internal compiler error: Segmentation fault: 11
Please submit a full bug report,
with preprocessed source if appropriate.
See <https://gcc.gnu.org/bugs/> for instructions.

any idea what the source of that could be @isuruf ?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'libblas' output doesn't have any tests.
  • It looks like the 'libtmglib' output doesn't have any tests.
  • It looks like the 'libcblas' output doesn't have any tests.
  • It looks like the 'liblapack' output doesn't have any tests.
  • It looks like the 'liblapacke' output doesn't have any tests.
  • It looks like the 'blas-devel' output doesn't have any tests.
  • It looks like the 'lapack' output doesn't have any tests.

@isuruf isuruf added the automerge Merge the PR when CI passes label Apr 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2021

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • drone: passed
  • travis: failed
  • azure: passed

Thus the PR was not passing and not merged.

@isuruf isuruf merged commit b5d2c4b into conda-forge:master Apr 9, 2021
@minrk minrk deleted the blas-devel-build branch June 21, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants