Merge pull request #4 from adibbley/fix-rpaths

Fix RPATH for libraries.
conda-forge · Dec 6, 2023 · 002edf2 · 002edf2
2 parents 71d19e7 + 086d03e
commit 002edf2
Show file tree

Hide file tree

Showing 12 changed files with 195 additions and 62 deletions.
diff --git a/.azure-pipelines/azure-pipelines-linux.yml b/.azure-pipelines/azure-pipelines-linux.yml
diff --git a/.azure-pipelines/azure-pipelines-win.yml b/.azure-pipelines/azure-pipelines-win.yml
diff --git a/.scripts/build_steps.sh b/.scripts/build_steps.sh
diff --git a/.scripts/logging_utils.sh b/.scripts/logging_utils.sh
diff --git a/.scripts/run_docker_build.sh b/.scripts/run_docker_build.sh
diff --git a/.scripts/run_win_build.bat b/.scripts/run_win_build.bat
diff --git a/.travis.yml b/.travis.yml
diff --git a/README.md b/README.md
diff --git a/conda-forge.yml b/conda-forge.yml
@@ -1,5 +1,5 @@
 conda_build:
-  error_overlinking: true
+  error_overlinking: false
 conda_forge_output_validation: true
 github:
   branch_name: main

diff --git a/recipe/build.sh b/recipe/build.sh
@@ -23,6 +23,10 @@ for i in `ls`; do
             for j in "$i"/*.so*; do
                 # Shared libraries are symlinked in $PREFIX/lib
                 ln -s ${PREFIX}/${targetsDir}/$j ${PREFIX}/$j
+
+                if [[ $j =~ \.so\. ]]; then
+                    patchelf --set-rpath '$ORIGIN' ${PREFIX}/${targetsDir}/$j
+                fi
             done
         fi
     else

diff --git a/recipe/meta.yaml b/recipe/meta.yaml
@@ -24,15 +24,21 @@ source:
   sha256: a7abd59e05b326d6adfca16840071d2ed02d0cc6df092d921ed96d489a2e864e  # [win]
 
 build:
-  number: 0
+  number: 1
+  binary_relocation: false
   skip: true  # [osx]
 
 test:
+  requires:
+    - patchelf  # [linux]
+  files:
+    - test-rpath.sh
   commands:
     - test -L $PREFIX/lib/libnppc.so.{{ version }}                                          # [linux]
     - test -L $PREFIX/lib/libnppc.so.{{ version.split(".")[0] }}                            # [linux]
     - test -L $PREFIX/targets/{{ target_name }}/lib/libnppc.so.{{ version.split(".")[0] }}  # [linux]
     - test -f $PREFIX/targets/{{ target_name }}/lib/libnppc.so.{{ version }}                # [linux]
+    - bash test-rpath.sh                                                                    # [linux]
     - if not exist %LIBRARY_BIN%\nppc64_{{ version.split(".")[0] }}.dll exit 1              # [win]
 
 outputs:
@@ -46,7 +52,8 @@ outputs:
         - {{ compiler("c") }}
         - {{ compiler("cxx") }}
         - arm-variant * {{ arm_variant_type }}  # [aarch64]
-        - sysroot_{{ target_platform }} 2.17  # [linux]
+        - sysroot_{{ target_platform }} 2.17    # [linux]
+        - patchelf <0.18.0                      # [linux]
       host:
          - cuda-version {{ cuda_version }}
       run:

diff --git a/recipe/test-rpath.sh b/recipe/test-rpath.sh
@@ -0,0 +1,24 @@
+#!/bin/bash
+
+[[ ${target_platform} == "linux-64" ]] && targetsDir="targets/x86_64-linux"
+[[ ${target_platform} == "linux-ppc64le" ]] && targetsDir="targets/ppc64le-linux"
+[[ ${target_platform} == "linux-aarch64" ]] && targetsDir="targets/sbsa-linux"
+
+errors=""
+
+for lib in `find ${PREFIX}/${targetsDir}/lib -type f`; do
+    [[ $lib =~ \.so ]] || continue
+
+    rpath=$(patchelf --print-rpath $lib)
+    echo "$lib rpath: $rpath"
+    [[ $rpath == "\$ORIGIN" ]] || errors+="$lib\n"
+done
+
+if [[ $errors ]]; then
+    echo "The following libraries were found with an unexpected RPATH:"
+    echo -e "$errors"
+
+    exit 1
+else
+    exit 0
+fi