Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pin_subpackage in run_exports and fix installation of CMake config in Windows #5

Merged
merged 3 commits into from
Mar 23, 2021

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Mar 19, 2021

Modification:

  • Use pin_subpackage in run_exports: to ensure that the version is taken in consideration in run_exports
  • The CMake config files were not include in the libode package on Windows, this PR includes them and check that they are correctly installed.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@traversaro traversaro requested a review from repagh as a code owner March 19, 2021 10:29
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor Author

fyi @wolfv

@wolfv
Copy link
Member

wolfv commented Mar 19, 2021

Yep, that should be much better. Without the pin_subpackage it would only add libode to the run requirements, but without a lower or upper bound afaik.

@traversaro
Copy link
Contributor Author

Yep, that should be much better. Without the pin_subpackage it would only add libode to the run requirements, but without a lower or upper bound afaik.

Yes, the problem that I had in conda-forge/libignition-physics-feedstock#12 was exactly that, where libode 0.16.0 got installed but dart actually needed libode 0.16.2 .

@traversaro traversaro changed the title Use pin_subpackage in run_exports Use pin_subpackage in run_exports and fix installation of CMake config in Windows Mar 19, 2021
@traversaro
Copy link
Contributor Author

To avoid having only a single maintainer for the recipe, if you like @repagh I can also add myself as a maintainer.

@repagh
Copy link
Contributor

repagh commented Mar 23, 2021

Thank you, looks good. And yes, if @traversaro want to join as maintainer, fine.

Glad to see more people have a use for libode

@repagh repagh merged commit c96999f into conda-forge:master Mar 23, 2021
@traversaro
Copy link
Contributor Author

Thanks @repagh ! I create a PR to add myself as mantainer to reduce the bus factor in #6 . Obviously I will wait for your opinion on all future PRs in any case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants