-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pin_subpackage in run_exports and fix installation of CMake config in Windows #5
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
Documentation on acceptable licenses can be found here. |
@conda-forge-admin, please rerender |
…da-forge-pinning 2021.03.19.08.01.08
fyi @wolfv |
Yep, that should be much better. Without the pin_subpackage it would only add |
Yes, the problem that I had in conda-forge/libignition-physics-feedstock#12 was exactly that, where libode 0.16.0 got installed but dart actually needed libode 0.16.2 . |
To avoid having only a single maintainer for the recipe, if you like @repagh I can also add myself as a maintainer. |
Thank you, looks good. And yes, if @traversaro want to join as maintainer, fine. Glad to see more people have a use for libode |
Thanks @repagh ! I create a PR to add myself as mantainer to reduce the bus factor in #6 . Obviously I will wait for your opinion on all future PRs in any case! |
Modification:
libode
package on Windows, this PR includes them and check that they are correctly installed.Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)