-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin to hdf5 1.8.17* #3
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@ocefpaf We need to get netcdf-cxx4 ready first. |
@ocefpaf @jakirkham The problem with So the dependency chain is as follows:
So the only place where hdf5 comes into play is |
Cool! I will update this PR once we get the others merged to see if we can drop the dependency over-specification. |
@ocefpaf This is blocked atm by |
@ocefpaf Can you restart the CI's here? Now, that the netcf-cxx4 thing is sorted out, we could try this here again. |
@ocefpaf nvm I just noticed that I could do it myself |
@kmuehlbauer this will need more thought. Does |
@ocefpaf I'll have a look into this. Thanks! |
@ocefpaf Found it. We're creating wrong library names in https://github.com/conda-forge/netcdf-cxx4-feedstock. It should be |
I guess the name changed in the update. I need to check netcdf-cxx4 code to be sure. |
Unidata is also producing |
I'll take a look. The only changes are the use of cmake and the update. Unidata is also producing libnetcdf_c++4 (travis-log — |
This was only half the truth. Obviously the @ocefpaf As you already suggested, a symlink should do the trick. Or just renaming as it mimicks the |
Lets's symlink and cover both naming. Will do soon. Just trying to find a bug in conda-smithy now... |
@kmuehlbauer conda-forge/netcdf-cxx4-feedstock#11 should fix the issue here. |
- cmake | ||
- boost 1.61.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kmuehlbauer I updated the boost pinning here. Is that OK?
run: | ||
- boost 1.60.* | ||
- hdf5 1.8.15* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we pin netcdf-cxx4
we don't need to add the hdf5
pin here b/c the right libnetcdf
/hdf5
will be downloaded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we pin netcdf-cxx4 we don't need to add the hdf5 pin here b/c the right libnetcdf/hdf5 will be downloaded.
That had historic reasons b/c that time this fixed some wrongly pulled hdf5. Now it won't be needed any more.
Travis Problems, we have to wait. |
@ocefpaf We had this before, I think, conda-forge/netcdf-cxx4-feedstock#5 This has to be some problem with libc++ / stdlibc++. We should have cmake and make output more verbos to see what is going on here. |
There is an ongoing conversation on |
We should also not forget, that |
@kmuehlbauer success! 🎉 |
Looks clean AFAICT. |
@ocefpaf @jakirkham great news. Will check this soon. Now let's merge this. |
@kmuehlbauer I am pinning against the latest hdf5 available in conda-forge. This will be used in all packages soon. Please take a look at it and merge if you think it is OK.
Needs: conda-forge/netcdf-cxx4-feedstock#7 and conda-forge/libnetcdf-feedstock#1