Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.5.4 #204

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Release 1.5.4 #204

merged 4 commits into from
Dec 5, 2023

Conversation

JohanMabille
Copy link
Contributor

@JohanMabille JohanMabille commented Dec 5, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@JohanMabille
Copy link
Contributor Author

@conda-forge-admin, please rerender

recipe/meta.yaml Outdated
@@ -127,7 +127,7 @@ outputs:
- {{ pin_subpackage('libmambapy', exact=True) }}
run:
- python
- conda >=23.9,<24
- conda >=23.11,<24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the comments from, e.g., mamba-org/mamba#3033 (comment) and conda-forge/conda-forge-repodata-patches-feedstock#608 (comment), it would make sense to have this as

Suggested change
- conda >=23.11,<24
- conda >=23.11,<23.12

. Whenever there is a new conda release for which mamba is still compatible with, we can just relax the constraint and issue a new build here.

@mbargull
Copy link
Member

mbargull commented Dec 5, 2023

Thanks everyone for the quick handling of this!

@JohanMabille
Copy link
Contributor Author

JohanMabille commented Dec 5, 2023

Not sure to understand, the build fails with : "Error: package/version missing in: '/home/conda/recipe_root/meta.yaml'", but we never had a package/version in this recipes (since it's a split package, we have a version per output). Were new tests added recently?

@mbargull
Copy link
Member

mbargull commented Dec 5, 2023

Not sure to understand, the build fails with : "Error: package/version missing in: '/home/conda/recipe_root/meta.yaml'", but we never had a package/version in this recipes (since it's a split package, we have a version per output). Were new tests added recently?

conda-forge/conda-build-feedstock#210 has also been merge today -- probably some kind of change(/regression?!?) in conda-build=3.28.

@SylvainCorlay
Copy link
Member

conda-forge/conda-build-feedstock#210 has also been merge today -- probably some kind of change(/regression?!?) in conda-build=3.28.

Indeed, should we mark conda-build 3.28 as broken?

@mattwthompson
Copy link
Member

mattwthompson commented Dec 5, 2023

Here's something in the diff that might be relevant (haven't dug deeply myself): conda/conda-build@3.27.0...3.28.0#diff-cf6e2d8905542a0e7aac26cae115f65b848dd3498b72a43051f0a8900de2c13cL684-R686

If that link doesn't open to the right lines: Files Changed -> search "package/version"

Change from blame: https://github.com/conda/conda-build/pull/5055/files

@JohanMabille
Copy link
Contributor Author

JohanMabille commented Dec 5, 2023

Thanks, let's add a version to the split package then, but there's a chance that this new version breaks a lot of recipes.

@mbargull
Copy link
Member

mbargull commented Dec 5, 2023

conda-forge/conda-build-feedstock#210 has also been merge today -- probably some kind of change(/regression?!?) in conda-build=3.28.

Indeed, should we mark conda-build 3.28 as broken?

Could you open a PR at https://github.com/conda-forge/admin-requests ?

@@ -6,6 +6,7 @@

package:
name: mamba-split
version: {{ release }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment that it is a workaround?

@JohanMabille
Copy link
Contributor Author

JohanMabille commented Dec 5, 2023

conda-forge/conda-build-feedstock#210 has also been merge today -- probably some kind of change(/regression?!?) in conda-build=3.28.

Indeed, should we mark conda-build 3.28 as broken?

Could you open a PR at https://github.com/conda-forge/admin-requests ?

See conda-forge/admin-requests#890

@jezdez
Copy link
Member

jezdez commented Dec 5, 2023

Just a note that we've seen this and we're coordinating a response

@mbargull
Copy link
Member

mbargull commented Dec 5, 2023

CI went through. Good to merge?

@mbargull
Copy link
Member

mbargull commented Dec 5, 2023

CI went through. Good to merge?

Sorry for being pushy on this.
Thing is just that any user of mamba which does a conda update --all/mamba update --all will break mamba as of now, see mamba-org/mamba#3033 (comment) .

@JohanMabille JohanMabille merged commit 5d0b5c0 into conda-forge:main Dec 5, 2023
8 checks passed
@JohanMabille
Copy link
Contributor Author

CI went through. Good to merge?

Sorry for being pushy on this. Thing is just that any user of mamba which does a conda update --all/mamba update --all will break mamba as of now, see mamba-org/mamba#3033 (comment) .

No worries, sorry for the delay, I've been preempted

@JohanMabille JohanMabille deleted the 154 branch December 5, 2023 18:59
@mbargull
Copy link
Member

mbargull commented Dec 5, 2023

Thanks, appreciated! Bonne soirée!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants