-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.5.4 #204
Release 1.5.4 #204
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.12.05.11.44.25
recipe/meta.yaml
Outdated
@@ -127,7 +127,7 @@ outputs: | |||
- {{ pin_subpackage('libmambapy', exact=True) }} | |||
run: | |||
- python | |||
- conda >=23.9,<24 | |||
- conda >=23.11,<24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the comments from, e.g., mamba-org/mamba#3033 (comment) and conda-forge/conda-forge-repodata-patches-feedstock#608 (comment), it would make sense to have this as
- conda >=23.11,<24 | |
- conda >=23.11,<23.12 |
. Whenever there is a new conda
release for which mamba
is still compatible with, we can just relax the constraint and issue a new build here.
Thanks everyone for the quick handling of this! |
Not sure to understand, the build fails with : "Error: package/version missing in: '/home/conda/recipe_root/meta.yaml'", but we never had a package/version in this recipes (since it's a split package, we have a version per output). Were new tests added recently? |
conda-forge/conda-build-feedstock#210 has also been merge today -- probably some kind of change(/regression?!?) in |
Indeed, should we mark conda-build 3.28 as broken? |
Here's something in the diff that might be relevant (haven't dug deeply myself): conda/conda-build@3.27.0...3.28.0#diff-cf6e2d8905542a0e7aac26cae115f65b848dd3498b72a43051f0a8900de2c13cL684-R686 If that link doesn't open to the right lines: Files Changed -> search "package/version" Change from blame: https://github.com/conda/conda-build/pull/5055/files |
Thanks, let's add a version to the split package then, but there's a chance that this new version breaks a lot of recipes. |
Could you open a PR at https://github.com/conda-forge/admin-requests ? |
@@ -6,6 +6,7 @@ | |||
|
|||
package: | |||
name: mamba-split | |||
version: {{ release }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a comment that it is a workaround?
|
Just a note that we've seen this and we're coordinating a response |
CI went through. Good to merge? |
Sorry for being pushy on this. |
No worries, sorry for the delay, I've been preempted |
Thanks, appreciated! Bonne soirée! |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)