Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to conda 23.10 and mamba 1.5.3 #496

Closed
wants to merge 6 commits into from

Conversation

hmaarrfk
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@hmaarrfk hmaarrfk requested a review from a team as a code owner September 29, 2023 11:54
Miniforge3/construct.yaml Outdated Show resolved Hide resolved
@hmaarrfk
Copy link
Contributor Author

@conda-forge/boa I'm curious why the solver can't find a solution for boa and mamba 1.5.1

https://github.com/conda-forge/boa-feedstock/blob/main/recipe/meta.yaml#L27


+ mamba install mamba=1.5.1 'python=3.10.*=*_cpython' boa --yes

Looking for: ['mamba=1.5.1', 'python=3.10[build=*_cpython]', 'boa']

Could not solve for environment specs
The following packages are incompatible
├─ boa is installable with the potential options
│  ├─ boa [0.2.1|0.3.0] would require
│  │  └─ mamba >=0.6.4,<0.15.0a0 , which can be installed;
│  ├─ boa [0.3.1|0.3.2|...|0.4.3] would require
│  │  └─ mamba >=0.7,<0.15.0a0 , which can be installed;
│  ├─ boa 0.5.0 would require
│  │  └─ mamba >=0.11,<0.15.0a0 , which can be installed;
│  ├─ boa 0.6.0 would require
│  │  └─ mamba >=0.14,<0.16 , which can be installed;
│  ├─ boa [0.6.1|0.6.2] would require
│  │  └─ mamba >=0.15,<0.16 , which can be installed;
│  ├─ boa [0.1.0|0.1.2|0.1.3|0.1.4] would require
│  │  └─ mamba 0.5.* , which can be installed;
│  ├─ boa 0.10.0 would require
│  │  └─ mamba >=0.22.0,<0.23 , which can be installed;
│  ├─ boa 0.11.0 would require
│  │  └─ mamba >=0.23.0,<0.24 , which can be installed;
│  ├─ boa 0.11.0 would require
│  │  └─ mamba >=0.23.0,<0.25 , which can be installed;
│  ├─ boa 0.11.0 would require
│  │  └─ mamba >=0.23.0,<0.26 , which can be installed;
│  ├─ boa 0.11.0 would require
│  │  └─ mamba >=0.23.0,<0.28 , which can be installed;
│  ├─ boa 0.12.0 would require
│  │  └─ mamba >=0.27.0,<0.28 , which can be installed;
│  ├─ boa 0.13.0 would require
│  │  └─ mamba >=1.0,<1.1 , which can be installed;
│  ├─ boa 0.2.0 would require
│  │  └─ mamba 0.6.* , which can be installed;
│  ├─ boa [0.7.0|0.7.1] would require
│  │  └─ mamba >=0.16,<0.18 , which can be installed;
│  ├─ boa 0.8.0 would require
│  │  └─ mamba >=0.18,<0.19 , which can be installed;
│  ├─ boa [0.8.1|0.8.2] would require
│  │  └─ mamba >=0.19.1,<0.20 , which can be installed;
│  ├─ boa 0.9.0 would require
│  │  └─ mamba >=0.21.0,<0.22 , which can be installed;
│  ├─ boa 0.14.0 would require
│  │  └─ mamba >=1.0,<1.2 , which can be installed;
│  ├─ boa 0.14.0 would require
│  │  └─ mamba >=1.0,<1.4 , which can be installed;
│  ├─ boa 0.14.0 would require
│  │  └─ mamba >=1.0,<1.5 , which can be installed;
│  └─ boa 0.15.1 would require
│     └─ mamba >=1.0,<=1.4.2 , which can be installed;
└─ mamba 1.5.1**  is not installable because it conflicts with any installable versions previously reported.

let me know if you have ideas

@hmaarrfk
Copy link
Contributor Author

hmm, this is why conda-forge/admin-requests#811

@hmaarrfk hmaarrfk closed this Oct 30, 2023
@hmaarrfk hmaarrfk reopened this Oct 30, 2023
@hmaarrfk hmaarrfk closed this Nov 8, 2023
@hmaarrfk hmaarrfk reopened this Nov 8, 2023
@jezdez jezdez changed the title Update to conda 23.7 and mamba 1.5.1 Update to conda 23.10 and mamba 1.5.3 Nov 17, 2023
{% set conda_libmamba_solver_version = "23.3.0"%}
{% set mamba_version = "1.4.2"%}
{% set version = os.environ.get("MINIFORGE_VERSION", "23.10.0-0") %}
{% set conda_libmamba_solver_version = "23.11.0"%}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% set conda_libmamba_solver_version = "23.11.0"%}
{% set conda_libmamba_solver_version = "23.11.1"%}

@h-vetinari
Copy link
Member

There's now a boa release that's compatible with mamba 1.5. I've restarted the failed CI jobs.

@h-vetinari
Copy link
Member

The builds from https://anaconda.org/conda-forge/boa/files are not making it through the CDN at the moment...

@h-vetinari
Copy link
Member

This looks good now on all platforms except osx, where we get:

ImportError: dlopen(/Users/runner/conda/lib/python3.10/site-packages/libmambapy/bindings.cpython-310-darwin.so, 0x0002): Symbol not found: (_solver_ruleinfo2str)
  Referenced from: '/Users/runner/conda/lib/libmamba.2.0.0.dylib'
  Expected in: '/Users/runner/conda/lib/libsolv.1.dylib'

CC @jaimergp @wolfv

@jaimergp
Copy link
Member

Pin for latest libsolv 0.7.26. Let's see if that fixes it.

@mbargull
Copy link
Member

mbargull commented Nov 20, 2023

This fails on macOS during setup after installing constructor.
It doesn't use latest package versions overall.
We may want to update

miniforge_version="4.14.0-0"
condapkg="https://github.com/conda-forge/miniforge/releases/download/${miniforge_version}/Mambaforge-${miniforge_version}-MacOSX-${miniforge_arch}.sh"
if [ "$(uname -m)" = "x86_64" ]; then
conda_checksum="949f046b4404cc8e081807b048050e6642d8db5520c20d5158a7ef721fbf76c5"
elif [ "$(uname -m)" = "arm64" ]; then
conda_checksum="35d05a65e19b8e5d596964936ddd6023ae66d664a25ba291a52fec18f06a73b6"
to use newer versions for setup.
We apparently already use setup-miniconda for Windows -- could we just use that for macOS too instead?

@mbargull
Copy link
Member

@hmaarrfk, I've changed the macOS builds to use setup-miniconda and updated conda-libmamba-solver=23.11.1 in gh-518 -- feel free to merge or cherry-pick commits from that PR if they look sensible to you.

@mbargull
Copy link
Member

mbargull commented Nov 20, 2023

Also, the decision on if/when we should release this should be made after deciding on #511 (comment) ( conda/conda-libmamba-solver#386 ):

But some feedstocks are incompatible due to a bug I'm chasing in conda/conda-libmamba-solver#386. These feedstocks need boa for mambabuild.

@mbargull
Copy link
Member

Also, the decision on if/when we should release this should be made after deciding on #511 (comment) ( conda/conda-libmamba-solver#386 ):

But some feedstocks are incompatible due to a bug I'm chasing in conda/conda-libmamba-solver#386. These feedstocks need boa for mambabuild.

FYI, for anyone following along: gh-518 has been merge without addressing this at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants