Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to conda 23.11, mamba 1.5.5, libmamba_solver 23.12 #523

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Nov 26, 2023

This reverts #522 and in effect updates to 23.10 (or soon 23.11)

Closes #511

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@hmaarrfk hmaarrfk marked this pull request as draft November 26, 2023 21:56
@mbargull
Copy link
Member

Thanks @hmaarrfk.
I'll get back to you once we know more on when/how/if we get a new conda release with the mentioned issue resolved.

@mbargull
Copy link
Member

We have an build for mamba=1.5.5 pending at conda-forge/mamba-feedstock#206 .
Once that one is up, we can include that update here.

With conda=23.11.0 and mamba=1.5.5 we should have all major issues I know of covered and I'd say we could then finally proceed with a new Miniforge release :).

@jaimergp
Copy link
Member

jaimergp commented Dec 12, 2023

conda-libmamba-solver 23.12.0 is out now, solving the "KeyError" issues too.

Miniforge3/construct.yaml Outdated Show resolved Hide resolved
Miniforge3/construct.yaml Outdated Show resolved Hide resolved
@jaimergp
Copy link
Member

I think we should specify this key too: https://conda.github.io/constructor/construct-yaml/#user-requested-specs

This would allow us to have a cleaner history, without pinning key specs to certain versions. For example:

user_requested_specs:
{% if name.endswith("pypy3") %}
  - python 3.9.* *_pypy
{% else %}
  - python 3.10.*
{% endif %}
  - pip
  - conda >={{ version.split("-")[0] }}
  - mamba >={{ mamba_version }}
  - miniforge_console_shortcut 1.*  # [win]

Note we have left conda-libmamba-solver out so it's not in history and can freely move (conda requires it now). We only specify the "leave" nodes, and with >= constraints so they can be easily upgraded. This should alleviate issues like mamba-org/mamba#3033 (comment).

Miniforge3/construct.yaml Outdated Show resolved Hide resolved
@hmaarrfk hmaarrfk changed the title Update to 23.10 (or soon 23.11) Revert revert 23.10 Update to conda 23.11, mamba 1.5.5, libmamba_solver 23.12 Dec 13, 2023
@mbargull mbargull marked this pull request as ready for review December 15, 2023 23:32
@mbargull mbargull requested a review from a team as a code owner December 15, 2023 23:32
@mbargull
Copy link
Member

@hmaarrfk, @jaimergp, good to go?

@jakirkham
Copy link
Member

This would be a prerelease initially right?

Think ideally we would make the release official Monday or Tuesday in case we need hands available to resolve issues (should any arise)

@hmaarrfk
Copy link
Contributor Author

I think it makes sense to make the pre-release this weekend, then to make a release on monday

@jaimergp
Copy link
Member

Yep, I have some time to babysit the release this week.

@hmaarrfk
Copy link
Contributor Author

if somebody else presses merge, i can start the pre-release.

@beckermr
Copy link
Member

@mbargull @jaimergp @hmaarrfk can we get push this ahead? Shall I merge?

@mbargull
Copy link
Member

@mbargull @jaimergp @hmaarrfk can we get push this ahead? Shall I merge?

Ah, didn't notice @hmaarrfk's last comment.
Thanks for the ping.
Merge, merge

@mbargull mbargull merged commit 3649a47 into conda-forge:main Dec 21, 2023
24 checks passed
@hmaarrfk
Copy link
Contributor Author

how are we feeling about the latest conda-smithy woes. I haven't been keeping up with the details so I was hesitant to merge myself.

@hmaarrfk
Copy link
Contributor Author

Just FYI, prerelease started. we can mark it as release when we want to in an hour or so
https://github.com/conda-forge/miniforge/releases/tag/23.11.0-0

@mbargull
Copy link
Member

how are we feeling about the latest conda-smithy woes. I haven't been keeping up with the details so I was hesitant to merge myself.

That was just due to a minor change in conda-build=3.28.2 that broke an assumption in downstream smithy code.
ref: conda/conda-build#5125
It should be taken care of with the new smithy release and adjusted dependencies for older builds.
Shouldn't affect Miniforge.

Just FYI, prerelease started. we can mark it as release when we want to in an hour or so https://github.com/conda-forge/miniforge/releases/tag/23.11.0-0

Thanks!
(We had one build stalled; I restarted it and it just finished so that all release artifacts should be available now.)

@hmaarrfk
Copy link
Contributor Author

Ok. Seems like we are set. I won't have time to pull a release today in case of errors but I can help tomorrow.

If somebody else wants to take responsibility today then the tag seems ready to be marked as latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Release 23.10
5 participants