-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST: 1.21.x + blas variants #237
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Update for 1.21.0From 1 failure out of 64 for 1.20.3, there are now 4 (mostly flaky) failures. Note: travis seems to be hanging across the board, but should pass once restarted.. Same expectation for aarch, which is still stuck in a long queue. Will update this comment if necessary. The badnews:
Details
Build logs: win + blis + cpython 3.9: 12 failures
|
Finally opened an issue for blis: flame/blis#514 |
So I had to restart the CI because travis died (and I don't have restart rights). This now lead to the reappearance of numpy/numpy#19192, though exclusively for PyPy. @mattip @r-devulap, is it possible that something is messing with the glibc-detection used in numpy/numpy#19209 on PyPy? Also, I really don't understand why this passed an hour before (with the exact same commit). |
It may be run on different machines, some with AVX512 some without |
It seems NumPy master has extended |
97caedc
to
e39a327
Compare
After following @mattip's tip for investigating the SIMD capabilities of the agents again, we're basically reconfirming numpy/numpy#19192 (failing runs have |
However, the SIMD check did help to verify that the blis failures are not actually flaky, but happen in the presence of AVX512. |
@mattip, is |
Hi @h-vetinari looks like |
Thanks a lot for investigating! |
PyPy does not implement that value. I opened an issue in PyPy and a corresponding one in NumPy numpy/numpy#19385. Note that packaging.tags uses a ctypes workaround, but that seems like overkill for a problem that PyPy should solve. |
Thanks! :) |
PyPy issue is fixed. Is it worth making a patch and releasing a new pypy7.3.5 build? The next PyPy release will probably be a few months coming, and I don't know how common it is to use PyPy + centos7 |
I think that would be worthwhile, carrying a patch is not a big deal IMO.
Maybe I misunderstand, but CentOS 6/7 are just stand-ins for linux here, where PyPy usage is highest. |
I mis-stated the failing combination above. It is PyPy + glibc2.12, which was found on centos6, not centos7. Centos6 is EOL since Nov 2020. But for some reason the conda environment uses it. |
See here: conda-forge/conda-forge.github.io#1436 |
It's the same reason that numpy supports manylinux2010 (which is glibc 2.12). 😉 |
NumPy uses manylinux2010 not to support the outdated CentOS6, but because it still supports older linux versions that may not have pip v20. I am not sure conda has the same problem. |
A very similar one - once conda moves off of CentOS 6, the packages built for linux are not usable on older distros anymore. As can be seen from the issue I linked, a move away from this is on the horizon, but that wasn't realistic or desirable until quite recently. |
e39a327
to
c953db1
Compare
c953db1
to
fa6ffa4
Compare
Update for numpy 1.21.2: still all green! 🥳After 0 failure out of 76 for 1.21.1, we remained at 0 failures (out of 68; having removed the AVX512-specific runs for blis). Details
|
fa6ffa4
to
7e6d158
Compare
Update for numpy 1.21.3: still all green! 🥳After 0 failures out of 68 runs for 1.21.2, we remained at 0 failures. Details
|
very nice! |
7e6d158
to
735b0fa
Compare
Update for numpy 1.21.5: all green except PPC (as before)Due to the missing Notable
Details
Build logs: |
Nice. A heads-up that there is apparently a problem with the recently released OpenBLAS 0.3.19 and NumPy: see numpy/numpy#20660 |
Not expecting a 1.21.6 release, so closing this. |
This reverts commit 00a2283.
…nda-forge-pinning 2022.04.12.21.56.28
8fdf2df
to
589f670
Compare
Update for 1.21.6 (+ new PyPy builds and BLAS updates): all green except PPC (as before)Turns out I guessed wrong about:
Also, due to the rebuilds for pypy3.8/3.9, much less several relevant BLAS (& infrastructure) changes, it makes sense to do an update here. From 10 failures (PPC-only) out of 86 runs, we're now at 12 failures (PPC-only) out of 108 runs. Notable
Details
Build logs: |
Continuing the analysis from #227 & #196. Should not be merged for the same reasons as #227.