Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable PPC tests #268

Merged
merged 7 commits into from
Apr 27, 2022
Merged

Re-enable PPC tests #268

merged 7 commits into from
Apr 27, 2022

Conversation

h-vetinari
Copy link
Member

Now that travis is back, let's try to run the PPC tests; based on #263 to avoid more conflicts in conda-forge.yml

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

I don't understand what's up with Travis. All the logs here are cut off extremely early in the build (also in raw log), e.g.

+docker pull quay.io/condaforge/linux-anvil-ppc64le
Using default tag: latest
latest: Pulling from condaforge/linux-anvil-ppc64le
3fe478aaff9b: Pulling fs layer
ff29e75e0dc0: Pulling fs layer
3fe478aaff9b: Verifying Checksum
3fe478aaff9b: Download complete
3fe478aaff9b: Pull complete

@h-vetinari h-vetinari mentioned this pull request Apr 10, 2022
Closed
@h-vetinari
Copy link
Member Author

Still weird things happening on travis, like the log cutting out and then reappearing in the middle of the test suite:

+ mamba update --update-specs --yes --quiet --channel conda-forge conda-build pip boa conda-forge-ci-setup=3
........................................................................ [ 13%]
........................................................................ [ 13%]
.s........................s..x.......................................... [ 14%]

or

Attempting to finalize metadata for numpy
conda-forge/linux-ppc64le                                   Using cache
conda-forge/noarch                                          Using cache
Reloading output folder: /home/conda/feedstock_root/build_artifacts
.......................................................................... [ 73%]
........................................................................ [ 74%]
........................................................................ [ 74%]

Reloading the same job again removes all the intervening progress bars that had been printed.

@h-vetinari
Revert "skip test suite on PPC"
b828925 
This reverts commit 00a2283.
@h-vetinari
MNT: Re-rendered with conda-build 3.21.8, conda-smithy 3.19.0, and co…
f018d19 
…nda-forge-pinning 2022.04.10.22.41.35
@h-vetinari
switch off parallelism on ppc
99b6569
@h-vetinari
only run fast tests on travis
ffd3fe8
@h-vetinari
re-add a PPC-specific skip
c09691d 
Had been removed in f946a5f
since failures at the time weren't being counted (missing
sys.exit wrapper), and once the wrapper was added in conda-forge#250,
the test suite for PPC was disabled completely.
@h-vetinari h-vetinari mentioned this pull request Apr 11, 2022
Closed
@h-vetinari
Copy link
Member Author

@isuruf

Good news, this seems to be passing on PPC! 🥳

However, some jobs have garbled/non-existent logs - are we comfortable with trusting that the uploads will work correctly even if we cannot introspect the logs?

@h-vetinari h-vetinari changed the title WIP: Re-enable PPC tests Re-enable PPC tests Apr 11, 2022
@h-vetinari h-vetinari marked this pull request as ready for review April 11, 2022 00:55
@h-vetinari
Copy link
Member Author

@isuruf, any comment on your confidence in Travis, given that the logs do not seem introspectable?

It'd be nice to run the test suite for PPC again.

@h-vetinari
Copy link
Member Author

Ping @isuruf

isuruf
isuruf reviewed Apr 26, 2022
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
isuruf
isuruf reviewed Apr 26, 2022
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
isuruf
isuruf approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change needed

@h-vetinari
Copy link
Member Author

Thanks for taking a look. I don't mind the changes, but IMO they're redundant in the sense that we cannot run ppc-tests on azure either (due to the emulation problems; wondering if qemu 6.2 or 7.0 would help, but https://github.com/multiarch/qemu-user-static hasn't updated yet).

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Apr 26, 2022
@github-actions github-actions bot merged commit 76f37ab into conda-forge:main Apr 27, 2022
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • travis: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@h-vetinari h-vetinari deleted the ppc branch April 27, 2022 00:47
h-vetinari added a commit to h-vetinari/numpy-feedstock that referenced this pull request Jun 23, 2022
@h-vetinari
Revert "Re-enable PPC tests (conda-forge#268)"
785e1e5 
This reverts commit 76f37ab, reversing
changes made to 541cf25.
h-vetinari added a commit to h-vetinari/numpy-feedstock that referenced this pull request Jun 23, 2022
@h-vetinari
Revert "Revert "Re-enable PPC tests (conda-forge#268)""
63635e0 
This reverts commit 785e1e5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isuruf isuruf isuruf approved these changes

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner

@ocefpaf ocefpaf Awaiting requested review from ocefpaf ocefpaf is a code owner

@pelson pelson Awaiting requested review from pelson pelson is a code owner

@rgommers rgommers Awaiting requested review from rgommers rgommers is a code owner

@xhochy xhochy Awaiting requested review from xhochy xhochy is a code owner

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@h-vetinari @conda-forge-linter @isuruf