Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openmp 17.0.0.rc1 #98

Merged
merged 2 commits into from
Jul 30, 2023
Merged

openmp 17.0.0.rc1 #98

merged 2 commits into from
Jul 30, 2023

Conversation

h-vetinari
Copy link
Member

Waiting for builds from conda-forge/llvmdev-feedstock#233

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

h-vetinari
h-vetinari commented Jul 29, 2023
View reviewed changes
Copy link
Member Author

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would appreciate your input on this @isuruf

recipe/meta.yaml
Comment on lines 2 to 4
# check https://clang.llvm.org/docs/OpenMPSupport.html
# occasionally to see last fully supported openmp ver.
{% set openmp_ver = "4.5" %}
Copy link
Member Author

@h-vetinari h-vetinari Jul 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before 17.0.0 GA we still need to decide what to do with the OpenMP version. LLVM 17 now defaults to 5.1, even though most of 5.0 & 5.1 are ostensibly not implemented yet (according to the status page, which seems very stale however). I asked about this upstream several times, leading to llvm/llvm-project#63633, but no response so far.

See also #96 for some more details.

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Jul 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2023 •
edited
Loading

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@h-vetinari h-vetinari marked this pull request as ready for review July 30, 2023 04:28
@h-vetinari h-vetinari removed the automerge Merge the PR when CI passes label Jul 30, 2023
@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Jul 30, 2023
@h-vetinari h-vetinari mentioned this pull request Jul 30, 2023
Merged
10 tasks
@h-vetinari
Copy link
Member Author

Also needs the builds from conda-forge/clangdev-feedstock#237 now.

@github-actions github-actions bot merged commit 394f7d0 into conda-forge:rc Jul 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckermr beckermr Awaiting requested review from beckermr beckermr is a code owner

@inducer inducer Awaiting requested review from inducer inducer is a code owner

@isuruf isuruf Awaiting requested review from isuruf isuruf is a code owner

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@katietz katietz Awaiting requested review from katietz katietz is a code owner

@yesimon yesimon Awaiting requested review from yesimon yesimon is a code owner

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@h-vetinari