-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use CUDA #193
Update to use CUDA #193
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Should the tests be disabled when |
Maybe there is a way to link with |
Maybe add __cuda as the set of requirements for the test?
…On Thu, Apr 25, 2024, 18:50 Lisandro Dalcin ***@***.***> wrote:
Should the tests be disabled when libcuda.so is not present?
Maybe there is a way to link with libcuda.so from the stubs, perhaps via
setting LIBRARY_PATH (for the GCC+linker) and LD_LIBRARY_PATH (for the
dynamic linker) ? Or there are not even stubs to search for?
—
Reply to this email directly, view it on GitHub
<#193 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABHCKANY5PYFLOGYHOJ4DY3Y7EQ3BAVCNFSM6AAAAABGXHIA7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZXGYYTSMZQGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Nope, it didn't work. So maybe we will disable the test for those archs? Also, by looking at the logs, PETSc uses |
I'm not sure what do you mean exactly. Are you talking about passing |
16593c0
to
03734e6
Compare
@dalcinl Builds are clean, I'm skipping running the compiled tests for |
Stefano, if you know for a fact a build is broken and will not work, I believe the usual conda-forge approach to it is to skip it, simply because broken package files should not be published. Or this is just a CI testing issue, and the packages to work if installed in systems with newer enough GLIBC? Have you tried? In that case, then yes, we can move forward. Please confirm (or we can discuss it in person in a couple hours). |
@stefanozampini Just in case, can do it with two commits? One for the recipe/config changes, and another for the re-rendering changes from conda-smithy? Maybe this is not really necessary, but that's how I've always done it, and I prefer to follow established patterns in things I do not understand in full 😅. |
@leofang Any chance you can give a quick glance to the changes to |
You have CUDA 12 support added to your recipe, but no CI/CD pipelines spawned. I suggest that you manually add the CUDA 12 migrator to For complex recipes like this one, cupy-feedstock can be a good reference (for supporting both CUDA 11/12 which have different file layouts + many CUDA packages + Python + ...), but no big issue from a quick glance other than the missing CIs. |
We did, but we were not sure about the CUDA 12 migration, so @stefanozampini leaved it out. Now we know better. |
No worries, last time I heard we're preparing a doc refresher for conda-forge CUDA packages. It might take some time to finalize, sorry for the learning curve. Before it lands, feel free to ping me or anyone from |
@leofang, I see cupy feedstock only builds with 11.8 or 12.4 https://github.com/conda-forge/cupy-feedstock/blob/main/recipe/meta.yaml#L37. Is the idea to use 11.8 or 12.4 only? |
CuPy was built with both CUDA 11.8 & 12.4. The built packages can serve both CUDA 11.x and 12.x users, not limited to the build versions (but obviously some selected features will require a newer CUDA version). |
thanks. So, to support the same in PETSc, I need to copy-paste the ignore_run_exports paraphernalia and related run_constrained stuff that are in cupy? |
1acf150
to
5a2a842
Compare
@conda-forge-admin please rerender |
…nda-forge-pinning 2024.05.02.11.25.06
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Checklist
conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Things to do: