Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest SDK to build #412

Merged
merged 3 commits into from
Nov 28, 2020
Merged

Use latest SDK to build #412

merged 3 commits into from
Nov 28, 2020

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Nov 26, 2020

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@isuruf
Copy link
Member Author

isuruf commented Nov 26, 2020

@conda-forge-admin, rerender

@isuruf
Copy link
Member Author

isuruf commented Nov 26, 2020

@conda-forge/python, this is ready for review. 3.9.1.rc1 supports building with a new SDK and using an older MACOSX_DEPLOYMENT_TARGET

@mbargull
Copy link
Member

ref: python/cpython#23295

@isuruf, are there any additional post-build tests we should/could add?

@isuruf
Copy link
Member Author

isuruf commented Nov 26, 2020

I don't think so

@isuruf
Copy link
Member Author

isuruf commented Nov 26, 2020

Ready now

@mbargull mbargull mentioned this pull request Nov 27, 2020
Closed
5 tasks
@mbargull
Copy link
Member

Is it worthwhile to enable artifacts on Azure on this feedstock to let someone inspect used symbols, akin to #371 (comment) ?
(Sorry for these banal questions; I'm just trying to be cautious whilst not knowing much about Macs.)

@isuruf
Copy link
Member Author

isuruf commented Nov 27, 2020

I can test on a 10.9 machine after this is merged. It's on python_rc label anyway.

@isuruf
Copy link
Member Author

isuruf commented Nov 28, 2020

Going to merge to python_rc label and test

@isuruf isuruf merged commit 396abef into conda-forge:master Nov 28, 2020
@isuruf isuruf deleted the sdk branch November 28, 2020 22:21
@rggjan rggjan mentioned this pull request Dec 4, 2020
Closed
@xhochy xhochy mentioned this pull request Jan 18, 2021
Merged
@isuruf isuruf mentioned this pull request May 10, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham Awaiting requested review from jakirkham

@jjhelmus jjhelmus Awaiting requested review from jjhelmus

@mbargull mbargull Awaiting requested review from mbargull

@mingwandroid mingwandroid Awaiting requested review from mingwandroid

@msarahan msarahan Awaiting requested review from msarahan

@ocefpaf ocefpaf Awaiting requested review from ocefpaf

@pelson pelson Awaiting requested review from pelson

@scopatz scopatz Awaiting requested review from scopatz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isuruf @conda-forge-linter @mbargull